linux-kernel - RE: [PATCH 1/1] ASoC: codec: tlv320aic32x4: Fix reset GPIO check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PAXPR04MB8459B643427F1F0952F159A68856A@PAXPR04MB8459.eurprd04.prod.outlook.com>
Date: Wed, 16 Jul 2025 07:44:12 +0000
From: Peng Fan <peng.fan@....com>
To: Alexander Stein <alexander.stein@...tq-group.com>, Shenghao Ding
	<shenghao-ding@...com>, Kevin Lu <kevin-lu@...com>, Baojun Xu
	<baojun.xu@...com>, Liam Girdwood <lgirdwood@...il.com>, Mark Brown
	<broonie@...nel.org>, Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai
	<tiwai@...e.com>, Linus Walleij <linus.walleij@...aro.org>
CC: "linux-sound@...r.kernel.org" <linux-sound@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 1/1] ASoC: codec: tlv320aic32x4: Fix reset GPIO check

> Subject: [PATCH 1/1] ASoC: codec: tlv320aic32x4: Fix reset GPIO check
> 
> rstn_gpio being a GPIO descriptor the check is wrong (inverted) for
> releasing the reset of the codec.
> 
> Fixes: 790d5f8ee6f2 ("ASoC: codec: tlv320aic32x4: Convert to GPIO
> descriptors")
> Signed-off-by: Alexander Stein <alexander.stein@...tq-group.com>
> ---
> AFAICT this bug was introduced on v2 of the series which changed the
> validity check
> 
>  sound/soc/codecs/tlv320aic32x4.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/codecs/tlv320aic32x4.c
> b/sound/soc/codecs/tlv320aic32x4.c
> index 3b89980e9bcf2..7399080f8580c 100644
> --- a/sound/soc/codecs/tlv320aic32x4.c
> +++ b/sound/soc/codecs/tlv320aic32x4.c
> @@ -1388,7 +1388,7 @@ int aic32x4_probe(struct device *dev, struct
> regmap *regmap,
>  		return ret;
>  	}
> 
> -	if (!aic32x4->rstn_gpio) {
> +	if (aic32x4->rstn_gpio) {

Oops! Thanks for spotting this.

Reviewed-by: Peng Fan <peng.fan@....com>