linux-kernel - Re: [PATCH v1 1/2] dt-bindings: clock: mediatek: Describe MT6789 clock controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250716-manipulative-dormouse-of-current-9af4e6@krzk-bin>
Date: Wed, 16 Jul 2025 09:04:51 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Arseniy Velikanov <me@...merle.pw>
Cc: Michael Turquette <mturquette@...libre.com>, 
	Stephen Boyd <sboyd@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Matthias Brugger <matthias.bgg@...il.com>, 
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, Philipp Zabel <p.zabel@...gutronix.de>, 
	linux-clk@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org, 
	~postmarketos/upstreaming@...ts.sr.ht
Subject: Re: [PATCH v1 1/2] dt-bindings: clock: mediatek: Describe MT6789
 clock controllers

On Wed, Jul 16, 2025 at 02:22:20AM +0400, Arseniy Velikanov wrote:
> +properties:
> +  compatible:
> +    items:
> +      - enum:
> +          - mediatek,mt6789-afe
> +          - mediatek,mt6789-camsys
> +          - mediatek,mt6789-camsys-rawa
> +          - mediatek,mt6789-camsys-rawb
> +          - mediatek,mt6789-imgsys
> +          - mediatek,mt6789-imp-iic-wrap-c
> +          - mediatek,mt6789-imp-iic-wrap-en
> +          - mediatek,mt6789-imp-iic-wrap-w
> +          - mediatek,mt6789-ipesys
> +          - mediatek,mt6789-mdpsys
> +          - mediatek,mt6789-mfgcfg
> +          - mediatek,mt6789-vdecsys
> +          - mediatek,mt6789-vencsys
> +
> +  reg:
> +    maxItems: 1
> +
> +  '#clock-cells':
> +    const: 1
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    afe: clock-controller@...10000 {
> +        compatible = "mediatek,mt6789-afe";
> +        reg = <0x11210000 0x1000>;
> +        #clock-cells = <1>;
> +    };
> +

Drop the rest of nodes. One example is enough. They are ALL THE SAME.

...

> diff --git a/Documentation/devicetree/bindings/clock/mediatek,mt6789-sys-clock.yaml b/Documentation/devicetree/bindings/clock/mediatek,mt6789-sys-clock.yaml
> new file mode 100644
> index 000000000000..d6f70ee918ad
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/mediatek,mt6789-sys-clock.yaml
> @@ -0,0 +1,68 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/mediatek,mt6789-sys-clock.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MediaTek System Clock Controller for MT6789
> +
> +maintainers:
> +  - Arseniy Velikanov <me@...merle.pw>
> +
> +description:
> +  The Mediatek system clock controller provides various clocks and system configuration
> +  like reset and bus protection on MT6789.
> +
> +properties:
> +  compatible:
> +    items:
> +      - enum:
> +          - mediatek,mt6789-apmixedsys

Why this does not fit existing binding file? Or Mediatek maintainers
preference was to switch to one-binding-per-SoC?


> +          - mediatek,mt6789-topckgen
> +          - mediatek,mt6789-infracfg-ao
> +          - mediatek,mt6789-mcusys
> +      - const: syscon
> +
> +  reg:
> +    maxItems: 1
> +
> +  '#clock-cells':
> +    const: 1
> +
> +  '#reset-cells':
> +    const: 1
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    mcusys: syscon@...0000 {

Drop unused labels, everywhere.

Also, node name is supposed to be clock or reset controller, not syscon.

> +      compatible = "mediatek,mt6789-mcusys", "syscon";
> +      reg = <0xc530000 0x1000>;
> +      #clock-cells = <1>;
> +    };
> +

Drop the rest

Best regards,
Krzysztof