linux-kernel - Re: [PATCH v6 3/9] ASoC: dt-bindings: qcom,lpass-va-macro: Update bindings for clocks to support ADSP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250716-spirited-sage-ibis-dcfeb1@krzk-bin>
Date: Wed, 16 Jul 2025 09:51:17 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Prasad Kumpatla <quic_pkumpatl@...cinc.com>
Cc: Bjorn Andersson <andersson@...nel.org>, 
	Linus Walleij <linus.walleij@...aro.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Srinivas Kandagatla <srini@...nel.org>, Liam Girdwood <lgirdwood@...il.com>, 
	Mark Brown <broonie@...nel.org>, Konrad Dybcio <konradybcio@...nel.org>, 
	cros-qcom-dts-watchers@...omium.org, linux-arm-msm@...r.kernel.org, linux-gpio@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-sound@...r.kernel.org, 
	kernel@....qualcomm.com, Mohammad Rafi Shaik <mohammad.rafi.shaik@....qualcomm.com>
Subject: Re: [PATCH v6 3/9] ASoC: dt-bindings: qcom,lpass-va-macro: Update
 bindings for clocks to support ADSP

On Tue, Jul 15, 2025 at 11:30:44PM +0530, Prasad Kumpatla wrote:
> From: Mohammad Rafi Shaik <mohammad.rafi.shaik@....qualcomm.com>
> 
> Manage clock settings for ADSP solution. On Existing ADSP bypass
> solutions, the macro and dcodec GDSCs are enabled using power domains
> in lpass-va-macro which is not applicable for ADSP based platform.
> 
> Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@....qualcomm.com>
> Co-developed-by: Prasad Kumpatla <quic_pkumpatl@...cinc.com>
> Signed-off-by: Prasad Kumpatla <quic_pkumpatl@...cinc.com>
> ---
>  .../bindings/sound/qcom,lpass-va-macro.yaml   | 29 +++++++++++++++----
>  1 file changed, 23 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
> index f41deaa6f4df..aec654e6567e 100644
> --- a/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
> +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
> @@ -76,12 +76,29 @@ allOf:
>            contains:
>              const: qcom,sc7280-lpass-va-macro
>      then:
> -      properties:
> -        clocks:
> -          maxItems: 1
> -        clock-names:
> -          items:
> -            - const: mclk
> +      if:
> +        required:
> +          - power-domains
> +      then:
> +        properties:
> +          clocks:
> +            minItems: 1

Drop minItems

> +            maxItems: 1
> +          clock-names:
> +            oneOf:

Drop oneOf

> +              - items:  # for ADSP based platforms
> +                  - const: mclk
> +      else:
> +        properties:
> +          clocks:
> +            minItems: 1

minItems: 3

> +            maxItems: 3
> +          clock-names:
> +            oneOf:

Drop oneOf

...  or rebase on top of my change and make it only min/maxItems:

lore.kernel.org/r/20250716074957.102402-2-krzysztof.kozlowski@...aro.org

(or whatever gets merged first, I can also rebase my patch later).

> +              - items:  # for ADSP bypass based platforms
> +                  - const: mclk
> +                  - const: macro
> +                  - const: dcodec

Best regards,
Krzysztof