linux-kernel - Re: [PATCH] iio: adc: ad_sigma_delta: Select IIO_BUFFER_DMAENGINE and SPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250716085120.51e8c130@jic23-huawei>
Date: Wed, 16 Jul 2025 08:51:20 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: David Lechner <dlechner@...libre.com>
Cc: Nathan Chancellor <nathan@...nel.org>, Nuno Sá
 <nuno.sa@...log.com>, Andy Shevchenko <andy@...nel.org>,
 linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: adc: ad_sigma_delta: Select IIO_BUFFER_DMAENGINE
 and SPI_OFFLOAD

On Tue, 15 Jul 2025 10:40:45 -0500
David Lechner <dlechner@...libre.com> wrote:

> On 7/14/25 1:30 PM, Nathan Chancellor wrote:
> > CONFIG_AD_SIGMA_DELTA uses several symbols that it does not explicitly
> > select. If no other enabled driver selects them, the build fails with
> > either a linker failure if the driver is built in or a modpost failure
> > if the driver is a module.
> > 
> >   ld.lld: error: undefined symbol: devm_spi_offload_rx_stream_request_dma_chan
> >   ld.lld: error: undefined symbol: devm_iio_dmaengine_buffer_setup_with_handle
> >   ld.lld: error: undefined symbol: devm_spi_offload_trigger_get
> >   ld.lld: error: undefined symbol: devm_spi_offload_get
> >   ld.lld: error: undefined symbol: spi_offload_trigger_enable
> >   ld.lld: error: undefined symbol: spi_offload_trigger_disable
> > 
> > Select the necessary Kconfig symbols to include these functions in the
> > build to clear up the errors.
> > 
> > Fixes: 219da3ea842a ("iio: adc: ad_sigma_delta: add SPI offload support")
> > Signed-off-by: Nathan Chancellor <nathan@...nel.org>
> > ---  
> 
> Thanks for the fix.
> 
> Reviewed-by: David Lechner <dlechner@...libre.com>
> 

Applied to the togreg branch of iio.git and pushed out (briefly) as
testing for 0-day to take a look.

Thanks,

Jonathan