linux-kernel - Re: [PATCH] nvmet: Add support for FDP devices in fabrics passthru path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250716084301.aulmx23rmumae3ba@green245.gost>
Date: Wed, 16 Jul 2025 14:13:55 +0530
From: Nitesh Shetty <nj.shetty@...sung.com>
To: Christoph Hellwig <hch@....de>
Cc: Sagi Grimberg <sagi@...mberg.me>, Chaitanya Kulkarni <kch@...dia.com>,
	gost.dev@...sung.com, nitheshshetty@...il.com,
	linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nvmet: Add support for FDP devices in fabrics passthru
 path

On 15/07/25 10:09AM, Christoph Hellwig wrote:
>On Tue, Jul 15, 2025 at 11:48:04AM +0530, Nitesh Shetty wrote:
>> In nvmet passthru path FDP is disabled, because of failure of
>> admin_get_features FDP(0x1d) feature command.
>> Supporting this through nvmet_setup_passthru_command enables FDP.
>
>I don't think this is safe - the feature has endurance group scope
>and thus can affect other controllers not passed through as well.
>
Agree, how about only enabling only for nvme_admin_get_features,
but not for nvme_admin_set_features, something like below?

--- a/drivers/nvme/target/passthru.c
+++ b/drivers/nvme/target/passthru.c
@@ -533,6 +533,8 @@ u16 nvmet_parse_passthru_admin_cmd(struct nvmet_req *req)
  		case NVME_FEAT_HOST_ID:
  			req->execute = nvmet_execute_get_features;
  			return NVME_SC_SUCCESS;
+		case NVME_FEAT_FDP:
+			return nvmet_setup_passthru_command(req);
  		default:
  			return nvmet_passthru_get_set_features(req);
  		}

Thanks,
Nitesh