linux-kernel - Re: [PATCH next] mmc: loongson2: Fix error code in loongson2_mmc_resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <26b89619-63f8-4534-9f1c-12acc65502b4@loongson.cn>
Date: Wed, 16 Jul 2025 09:43:46 +0800
From: Binbin Zhou <zhoubinbin@...ngson.cn>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Ulf Hansson <ulf.hansson@...aro.org>, Huacai Chen
 <chenhuacai@...nel.org>, linux-mmc@...r.kernel.org,
 linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH next] mmc: loongson2: Fix error code in
 loongson2_mmc_resource_request()

Hi Dan:

Ah, sorry  for my cheap fault, and thanks for your patch.

On 2025/7/16 07:00, Dan Carpenter wrote:
> There is a cut and paste bug so we accidentally return the wrong
> variable.  It should be "ret" instead of PTR_ERR(host->clk).
>
> Fixes: 2115772014bd ("mmc: loongson2: Add Loongson-2K SD/SDIO controller driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>


Reviewed-by: Binbin Zhou <zhoubinbin@...ngson.cn>

> ---
>   drivers/mmc/host/loongson2-mmc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/loongson2-mmc.c b/drivers/mmc/host/loongson2-mmc.c
> index ba6bb8fd5535..63d01d2cd978 100644
> --- a/drivers/mmc/host/loongson2-mmc.c
> +++ b/drivers/mmc/host/loongson2-mmc.c
> @@ -887,7 +887,7 @@ static int loongson2_mmc_resource_request(struct platform_device *pdev,
>   	if (host->clk) {
>   		ret = devm_clk_rate_exclusive_get(dev, host->clk);
>   		if (ret)
> -			return PTR_ERR(host->clk);
> +			return ret;
>   
>   		host->current_clk = clk_get_rate(host->clk);
>   	} else {


Thanks.
Binbin