linux-kernel - Re: [PATCH liburing v2 0/3] Bring back `CONFIG_HAVE_MEMFD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3b28fddb-2171-4f2f-9729-0c0ed14d20cc@kernel.dk>
Date: Wed, 16 Jul 2025 06:41:10 -0600
From: Jens Axboe <axboe@...nel.dk>
To: Alviro Iskandar Setiawan <alviro.iskandar@...weeb.org>
Cc: Ammar Faizi <ammarfaizi2@...weeb.org>,
 GNU/Weeb Mailing List <gwml@...r.gnuweeb.org>,
 Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
 io-uring Mailing List <io-uring@...r.kernel.org>
Subject: Re: [PATCH liburing v2 0/3] Bring back `CONFIG_HAVE_MEMFD_CREATE` to
 fix Android build error

On 7/15/25 6:43 PM, Alviro Iskandar Setiawan wrote:
> Hello,
> 
> This is the v2 revision of the patch series to address the Android
> build error related to `memfd_create()`. The series consists of three
> patches:

Took a closer look at this. A few comments:

For patch 1, maybe just bring back the configure test and not bother
with a revert style commit? There is nothing in test/ that uses
memfd_create, so there's no point bringing it back in there.

IOW, patch 2 can be dropped, as it's really just dropping bits
that patch 1 re-added for some reason.

All that's needed is to add it to the examples/ helpers. If it's
needed for test/ later, then it can get added at that time.

All of that to say, I'd just add the configure bit and the examples/
helper in a single patch and not worry about test/ at all.

-- 
Jens Axboe