linux-kernel - Re: [PATCH] rtc: amlogic-a4: Optimize global variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <045fc0c4-417b-4fd5-8bcf-7c7c34fdb01e@web.de>
Date: Thu, 17 Jul 2025 17:42:12 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Xianwei Zhao <xianwei.zhao@...ogic.com>,
 linux-amlogic@...ts.infradead.org, linux-rtc@...r.kernel.org
Cc: LKML <linux-kernel@...r.kernel.org>,
 Alexandre Belloni <alexandre.belloni@...tlin.com>,
 Yiting Deng <yiting.deng@...ogic.com>
Subject: Re: [PATCH] rtc: amlogic-a4: Optimize global variables

> Use local variables struct regmap_config instread of global

            variable?                      instead?


> variables. The goal of saving memory has been achieve.

                                                achieved?

You may occasionally put more than 59 characters into text lines
of such a change description.


…
> ---
> Use local variables struct regmap_config instread of global
> variables. 
> ---
>  drivers/rtc/rtc-amlogic-a4.c | 14 +++++++-------
…

Please avoid duplicate information here.


Can a summary phrase like “Convert a global variable into a local one
of aml_rtc_probe()” be more appropriate?

Regards,
Markus