linux-kernel - Re: [PATCH] rtc: amlogic-a4: Optimize global variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f4037828-be67-4312-b6c5-d3b82a0876f5@amlogic.com>
Date: Mon, 21 Jul 2025 10:27:51 +0800
From: Xianwei Zhao <xianwei.zhao@...ogic.com>
To: Markus Elfring <Markus.Elfring@....de>,
 linux-amlogic@...ts.infradead.org, linux-rtc@...r.kernel.org
Cc: LKML <linux-kernel@...r.kernel.org>,
 Alexandre Belloni <alexandre.belloni@...tlin.com>,
 Yiting Deng <yiting.deng@...ogic.com>
Subject: Re: [PATCH] rtc: amlogic-a4: Optimize global variables

Hi Markus,
    Thanks for your advice.

On 2025/7/17 23:42, Markus Elfring wrote:
> [Some people who received this message don't often get email from markus.elfring@....de. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> [ EXTERNAL EMAIL ]
> 
>> Use local variables struct regmap_config instread of global
> 
>              variable?                      instead?
> 
> 
>> variables. The goal of saving memory has been achieve.
> 
>                                                  achieved?
> 
> You may occasionally put more than 59 characters into text lines
> of such a change description.
> 
> 
> …
>> ---
>> Use local variables struct regmap_config instread of global
>> variables.
>> ---
>>   drivers/rtc/rtc-amlogic-a4.c | 14 +++++++-------
> …
> 
> Please avoid duplicate information here.
> 
> 
> Can a summary phrase like “Convert a global variable into a local one
> of aml_rtc_probe()” be more appropriate?
> 

Will do.

> Regards,
> Markus