linux-kernel - Re: [PATCH v3 1/2] watchdog: it87

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5e471ef4-5303-4c7f-a7fa-e19f8fea0f8f@roeck-us.net>
Date: Wed, 16 Jul 2025 17:24:55 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 James Hilliard <james.hilliard1@...il.com>,
 Wolfram Sang <wsa+renesas@...g-engineering.com>,
 linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: Wim Van Sebroeck <wim@...ux-watchdog.org>
Subject: Re: [PATCH v3 1/2] watchdog: it87_wdt: Don't use "proxy" headers

On 7/8/25 06:33, Andy Shevchenko wrote:
> Update header inclusions to follow IWYU (Include What You Use)
> principle.
> 
> Note that kernel.h is discouraged to be included as it's written
> at the top of that file.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>   drivers/watchdog/it87_wdt.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/it87_wdt.c b/drivers/watchdog/it87_wdt.c
> index a1e23dce8810..3b8488c86a2f 100644
> --- a/drivers/watchdog/it87_wdt.c
> +++ b/drivers/watchdog/it87_wdt.c
> @@ -22,11 +22,13 @@
>   
>   #include <linux/bits.h>
>   #include <linux/dmi.h>
> +#include <linux/errno.h>
>   #include <linux/init.h>
>   #include <linux/io.h>
> -#include <linux/kernel.h>
> +#include <linux/ioport.h>
>   #include <linux/module.h>
>   #include <linux/moduleparam.h>
> +#include <linux/printk.h>
>   #include <linux/types.h>
>   #include <linux/watchdog.h>
>