linux-kernel - Re: [PATCH v3 2/2] watchdog: Don't use "proxy" headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c38edb68-e250-4c54-8a91-e678d3f1eae9@roeck-us.net>
Date: Wed, 16 Jul 2025 17:25:08 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 James Hilliard <james.hilliard1@...il.com>,
 Wolfram Sang <wsa+renesas@...g-engineering.com>,
 linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: Wim Van Sebroeck <wim@...ux-watchdog.org>
Subject: Re: [PATCH v3 2/2] watchdog: Don't use "proxy" headers

On 7/8/25 06:33, Andy Shevchenko wrote:
> Update header inclusions to follow IWYU (Include What You Use)
> principle.
> 
> Note that kernel.h is discouraged to be included as it's written
> at the top of that file.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>


Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>   drivers/watchdog/watchdog_core.h       |  8 +++++++-
>   drivers/watchdog/watchdog_pretimeout.c |  2 ++
>   include/linux/watchdog.h               | 12 ++++++++----
>   3 files changed, 17 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/watchdog/watchdog_core.h b/drivers/watchdog/watchdog_core.h
> index 5b35a8439e26..ab825d9f9248 100644
> --- a/drivers/watchdog/watchdog_core.h
> +++ b/drivers/watchdog/watchdog_core.h
> @@ -24,8 +24,14 @@
>    *	This material is provided "AS-IS" and at no charge.
>    */
>   
> -#include <linux/hrtimer.h>
> +#include <linux/cdev.h>
> +#include <linux/device.h>
> +#include <linux/hrtimer_types.h>
> +#include <linux/init.h>
>   #include <linux/kthread.h>
> +#include <linux/mutex_types.h>
> +#include <linux/types.h>
> +#include <linux/watchdog.h>
>   
>   #define MAX_DOGS	32	/* Maximum number of watchdog devices */
>   
> diff --git a/drivers/watchdog/watchdog_pretimeout.c b/drivers/watchdog/watchdog_pretimeout.c
> index e5295c990fa1..2526436dc74d 100644
> --- a/drivers/watchdog/watchdog_pretimeout.c
> +++ b/drivers/watchdog/watchdog_pretimeout.c
> @@ -7,6 +7,8 @@
>   #include <linux/slab.h>
>   #include <linux/spinlock.h>
>   #include <linux/string.h>
> +#include <linux/sysfs.h>
> +#include <linux/types.h>
>   #include <linux/watchdog.h>
>   
>   #include "watchdog_core.h"
> diff --git a/include/linux/watchdog.h b/include/linux/watchdog.h
> index 99660197a36c..8c60687a3e55 100644
> --- a/include/linux/watchdog.h
> +++ b/include/linux/watchdog.h
> @@ -9,14 +9,18 @@
>   #ifndef _LINUX_WATCHDOG_H
>   #define _LINUX_WATCHDOG_H
>   
> -
>   #include <linux/bitops.h>
> -#include <linux/cdev.h>
> -#include <linux/device.h>
> -#include <linux/kernel.h>
> +#include <linux/limits.h>
>   #include <linux/notifier.h>
> +#include <linux/printk.h>
> +#include <linux/types.h>
> +
>   #include <uapi/linux/watchdog.h>
>   
> +struct attribute_group;
> +struct device;
> +struct module;
> +
>   struct watchdog_ops;
>   struct watchdog_device;
>   struct watchdog_core_data;