linux-kernel - Re: [Intel-wired-lan] [PATCH iwl-next v1] ixgbevf: remove unused fields from struct ixgbevf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d4144828-f266-4a57-a78c-55a3b20b8cf7@intel.com>
Date: Thu, 17 Jul 2025 13:08:12 -0700
From: Tony Nguyen <anthony.l.nguyen@...el.com>
To: "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>, Yuto Ohnuki
	<ytohnuki@...zon.com>, "Kitszel, Przemyslaw" <przemyslaw.kitszel@...el.com>
CC: Andrew Lunn <andrew+netdev@...n.ch>, "David S . Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v1] ixgbevf: remove unused
 fields from struct ixgbevf_adapter



On 7/17/2025 2:33 AM, Loktionov, Aleksandr wrote:
> 
> 
>> -----Original Message-----
>> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf
>> Of Yuto Ohnuki
>> Sent: Thursday, July 17, 2025 10:46 AM
>> To: Nguyen, Anthony L <anthony.l.nguyen@...el.com>; Kitszel,
>> Przemyslaw <przemyslaw.kitszel@...el.com>
>> Cc: Andrew Lunn <andrew+netdev@...n.ch>; David S . Miller
>> <davem@...emloft.net>; Eric Dumazet <edumazet@...gle.com>; Jakub
>> Kicinski <kuba@...nel.org>; Paolo Abeni <pabeni@...hat.com>; intel-
>> wired-lan@...ts.osuosl.org; netdev@...r.kernel.org; linux-
>> kernel@...r.kernel.org; Yuto Ohnuki <ytohnuki@...zon.com>
>> Subject: [Intel-wired-lan] [PATCH iwl-next v1] ixgbevf: remove unused
>> fields from struct ixgbevf_adapter
>>
>> Remove hw_rx_no_dma_resources and eitr_param fields from struct
>> ixgbevf_adapter since these fields are never referenced in the driver.
>>
>> Note that the interrupt throttle rate is controlled by the
>> rx_itr_setting and tx_itr_setting variables.
>>
>> This change simplifies the ixgbevf driver by removing unused fields,
>> which improves maintainability.
>>
>> Signed-off-by: Yuto Ohnuki <ytohnuki@...zon.com>
> Can you add 'Fixes:' or 'Cleanup:' tag ?

As there's no user bug, I don't believe this warrants a Fixes: tag.

I'm not familiar with a Cleanup: tag; on quick browse of git log, I'm 
not seeing one being used(?)

Thanks,
Tony

> 
> Alex
>> ---
>>   drivers/net/ethernet/intel/ixgbevf/ixgbevf.h | 3 ---
>>   1 file changed, 3 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h
>> b/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h
>> index 4384e892f967..3a379e6a3a2a 100644
>> --- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h
>> +++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h
>> @@ -346,7 +346,6 @@ struct ixgbevf_adapter {
>>   	int num_rx_queues;
>>   	struct ixgbevf_ring *rx_ring[MAX_TX_QUEUES]; /* One per active
>> queue */
>>   	u64 hw_csum_rx_error;
>> -	u64 hw_rx_no_dma_resources;
>>   	int num_msix_vectors;
>>   	u64 alloc_rx_page_failed;
>>   	u64 alloc_rx_buff_failed;
>> @@ -363,8 +362,6 @@ struct ixgbevf_adapter {
>>   	/* structs defined in ixgbe_vf.h */
>>   	struct ixgbe_hw hw;
>>   	u16 msg_enable;
>> -	/* Interrupt Throttle Rate */
>> -	u32 eitr_param;
>>
>>   	struct ixgbevf_hw_stats stats;
>>
>> --
>> 2.47.1
>>
>>
>>
>>
>> Amazon Web Services EMEA SARL, 38 avenue John F. Kennedy, L-1855
>> Luxembourg, R.C.S. Luxembourg B186284
>>
>> Amazon Web Services EMEA SARL, Irish Branch, One Burlington Plaza,
>> Burlington Road, Dublin 4, Ireland, branch registration number 908705
>>
>>
>