| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <IA3PR11MB89861BE40BCCFED551B067D5E55DA@IA3PR11MB8986.namprd11.prod.outlook.com>
Date: Mon, 21 Jul 2025 11:47:29 +0000
From: "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>
To: "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>, Yuto Ohnuki
<ytohnuki@...zon.com>, "Kitszel, Przemyslaw" <przemyslaw.kitszel@...el.com>
CC: Andrew Lunn <andrew+netdev@...n.ch>, "David S . Miller"
<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [Intel-wired-lan] [PATCH iwl-next v1] ixgbevf: remove unused
fields from struct ixgbevf_adapter
> -----Original Message-----
> From: Nguyen, Anthony L <anthony.l.nguyen@...el.com>
> Sent: Thursday, July 17, 2025 10:08 PM
> To: Loktionov, Aleksandr <aleksandr.loktionov@...el.com>; Yuto Ohnuki
> <ytohnuki@...zon.com>; Kitszel, Przemyslaw
> <przemyslaw.kitszel@...el.com>
> Cc: Andrew Lunn <andrew+netdev@...n.ch>; David S . Miller
> <davem@...emloft.net>; Eric Dumazet <edumazet@...gle.com>; Jakub
> Kicinski <kuba@...nel.org>; Paolo Abeni <pabeni@...hat.com>; intel-
> wired-lan@...ts.osuosl.org; netdev@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Subject: Re: [Intel-wired-lan] [PATCH iwl-next v1] ixgbevf: remove
> unused fields from struct ixgbevf_adapter
>
>
>
> On 7/17/2025 2:33 AM, Loktionov, Aleksandr wrote:
> >
> >
> >> -----Original Message-----
> >> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On
> Behalf
> >> Of Yuto Ohnuki
> >> Sent: Thursday, July 17, 2025 10:46 AM
> >> To: Nguyen, Anthony L <anthony.l.nguyen@...el.com>; Kitszel,
> >> Przemyslaw <przemyslaw.kitszel@...el.com>
> >> Cc: Andrew Lunn <andrew+netdev@...n.ch>; David S . Miller
> >> <davem@...emloft.net>; Eric Dumazet <edumazet@...gle.com>; Jakub
> >> Kicinski <kuba@...nel.org>; Paolo Abeni <pabeni@...hat.com>; intel-
> >> wired-lan@...ts.osuosl.org; netdev@...r.kernel.org; linux-
> >> kernel@...r.kernel.org; Yuto Ohnuki <ytohnuki@...zon.com>
> >> Subject: [Intel-wired-lan] [PATCH iwl-next v1] ixgbevf: remove
> unused
> >> fields from struct ixgbevf_adapter
> >>
> >> Remove hw_rx_no_dma_resources and eitr_param fields from struct
> >> ixgbevf_adapter since these fields are never referenced in the
> driver.
> >>
> >> Note that the interrupt throttle rate is controlled by the
> >> rx_itr_setting and tx_itr_setting variables.
> >>
> >> This change simplifies the ixgbevf driver by removing unused
> fields,
> >> which improves maintainability.
> >>
> >> Signed-off-by: Yuto Ohnuki <ytohnuki@...zon.com>
> > Can you add 'Fixes:' or 'Cleanup:' tag ?
>
> As there's no user bug, I don't believe this warrants a Fixes: tag.
>
> I'm not familiar with a Cleanup: tag; on quick browse of git log, I'm
> not seeing one being used(?)
>
> Thanks,
> Tony
>
Good day, Tony
Examples of the tag could be get: git log --grep="^Cleanup:" --oneline
ff9fb2e Merge tag 'samsung-soc-5.19' of git://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux into arm/soc
15b5b76 Merge tag 'samsung-soc-5.19' of git://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux into arm/drivers
566d336 mm: warn on deleting redirtied only if accounted
35189b8 kernel/acct.c: use #elif instead of #end and #elif
0bbe4ce iommu/amd: Fix the overwritten field in IVMD header
521ec1c Merge tag 'renesas-dt-bindings-for-v4.18' of https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas into next/dt
878e917 Merge tag 'renesas-dt2-for-v4.13' of https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas into next/dt
c3acc32 Merge tag 'renesas-arm64-dt2-for-v4.12' of https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas into next/dt64
8855e14 Merge tag 'renesas-dt-for-v4.12' of https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas into next/dt
5344df6 Merge tag 'renesas-arm64-dt-for-v4.12' of https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas into next/dt64
837a90e netfilter: ipset: Regroup ip_set_put_extensions and add extern
...
> >
> > Alex
> >> ---
> >> drivers/net/ethernet/intel/ixgbevf/ixgbevf.h | 3 ---
> >> 1 file changed, 3 deletions(-)
> >>
> >> diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h
> >> b/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h
> >> index 4384e892f967..3a379e6a3a2a 100644
> >> --- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h
> >> +++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h
> >> @@ -346,7 +346,6 @@ struct ixgbevf_adapter {
> >> int num_rx_queues;
> >> struct ixgbevf_ring *rx_ring[MAX_TX_QUEUES]; /* One per active
> >> queue */
> >> u64 hw_csum_rx_error;
> >> - u64 hw_rx_no_dma_resources;
> >> int num_msix_vectors;
> >> u64 alloc_rx_page_failed;
> >> u64 alloc_rx_buff_failed;
> >> @@ -363,8 +362,6 @@ struct ixgbevf_adapter {
> >> /* structs defined in ixgbe_vf.h */
> >> struct ixgbe_hw hw;
> >> u16 msg_enable;
> >> - /* Interrupt Throttle Rate */
> >> - u32 eitr_param;
> >>
> >> struct ixgbevf_hw_stats stats;
> >>
> >> --
> >> 2.47.1
> >>
> >>
> >>
> >>
> >> Amazon Web Services EMEA SARL, 38 avenue John F. Kennedy, L-1855
> >> Luxembourg, R.C.S. Luxembourg B186284
> >>
> >> Amazon Web Services EMEA SARL, Irish Branch, One Burlington Plaza,
> >> Burlington Road, Dublin 4, Ireland, branch registration number
> 908705
> >>
> >>
> >
Powered by blists - more mailing lists