linux-kernel - Re: [PATCH v6 2/2] arm64: dts: qcom: add initial support for Samsung Galaxy S22

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1ca25402-8f57-468c-b4d5-7b52f526ab28@oss.qualcomm.com>
Date: Thu, 17 Jul 2025 22:19:49 +0200
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Violet <violet@....tools>, Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 2/2] arm64: dts: qcom: add initial support for Samsung
 Galaxy S22

On 7/17/25 1:17 AM, Violet wrote:
> Add new device support for the Samsung Galaxy S22 (SM-S901E) phone
> 
> What works:
> - SimpleFB
> - USB
> 
> Signed-off-by: Violet <violet@....tools>
> ---

[...]

> +&tlmm {
> +	gpio-reserved-ranges = <36 4>, <50 1>;

Do you know what these are connected to?

We tend to document it, see e.g. x1-crd.dtsi

> +};
> +
> +&usb_1 {
> +	/* USB 2.0 only */
> +	qcom,select-utmi-as-pipe-clk;

Is that a hardware limitation? I thought these phones had the necessary
pins connected (for DeX)..

> +	status = "okay";

A newline before 'status' is good practice, file-wide

Konrad