linux-kernel - Re: [PATCH v6 2/2] arm64: dts: qcom: add initial support for Samsung Galaxy S22

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9d13d012-8b10-4094-bea0-b85e799ff0c5@atl.tools>
Date: Tue, 29 Jul 2025 11:46:00 +0000
From: Violet <violet@....tools>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 2/2] arm64: dts: qcom: add initial support for Samsung
 Galaxy S22

On 7/17/25 20:19, Konrad Dybcio wrote:

> On 7/17/25 1:17 AM, Violet wrote:
>> Add new device support for the Samsung Galaxy S22 (SM-S901E) phone
>>
>> What works:
>> - SimpleFB
>> - USB
>>
>> Signed-off-by: Violet <violet@....tools>
>> ---
> [...]
>
>> +&tlmm {
>> +	gpio-reserved-ranges = <36 4>, <50 1>;
> Do you know what these are connected to?
>
> We tend to document it, see e.g. x1-crd.dtsi
>
>> +};
>> +
>> +&usb_1 {
>> +	/* USB 2.0 only */
>> +	qcom,select-utmi-as-pipe-clk;
> Is that a hardware limitation? I thought these phones had the necessary
> pins connected (for DeX)..
>
>> +	status = "okay";
> A newline before 'status' is good practice, file-wide
>
> Konrad

Thank you, I'll fix these issues on the next patchset. Indeed it is not a

hardware limitation, I just kept it USB 2.0 for now to avoid any

potential issues with 3.0.