linux-kernel - Re: [PATCH v2] arm64: Mark kernel as tainted on SAE and SError panic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aHjJJf4KTzXLBjM0@willie-the-truck>
Date: Thu, 17 Jul 2025 10:57:57 +0100
From: Will Deacon <will@...nel.org>
To: Breno Leitao <leitao@...ian.org>
Cc: Mark Rutland <mark.rutland@....com>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Len Brown <lenb@...nel.org>, James Morse <james.morse@....com>,
	Tony Luck <tony.luck@...el.com>, Borislav Petkov <bp@...en8.de>,
	Robert Moore <robert.moore@...el.com>, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org, acpica-devel@...ts.linux.dev,
	kernel-team@...a.com, Catalin Marinas <catalin.marinas@....com>,
	osandov@...com, leo.yan@....com, rmikey@...a.com
Subject: Re: [PATCH v2] arm64: Mark kernel as tainted on SAE and SError panic

On Wed, Jul 16, 2025 at 03:52:55AM -0700, Breno Leitao wrote:
> On Wed, Jul 16, 2025 at 11:19:38AM +0100, Mark Rutland wrote:
> > On Wed, Jul 16, 2025 at 02:42:01AM -0700, Breno Leitao wrote:
> > > Set TAINT_MACHINE_CHECK when SError or Synchronous External Abort (SEA)
> > > interrupts trigger a panic to flag potential hardware faults. This
> > > tainting mechanism aids in debugging and enables correlation of
> > > hardware-related crashes in large-scale deployments.
> > > 
> > > This change aligns with similar patches[1] that mark machine check
> > > events when the system crashes due to hardware errors.
> > > 
> > > Link: https://lore.kernel.org/all/20250702-add_tain-v1-1-9187b10914b9@debian.org/ [1]
> > > Signed-off-by: Breno Leitao <leitao@...ian.org>
> > > ---
> > > Changes in v2:
> > > - Also taint the kernel on Synchronous External Abort panics (Will Deacon)
> > > - Link to v1: https://lore.kernel.org/r/20250714-vmcore_hw_error-v1-1-8cf45edb6334@debian.org
> > 
> > I think something went wrong when respinning this patch, because the v1
> > link above is incorrect, and should be:
> > 
> >   https://lore.kernel.org/linux-arm-kernel/20250710-arm_serror-v1-1-2a3def3740d7@debian.org/
> > 
> > The Cc header for this posting matches that of the unrelated patch (and
> > excludes Will, Catalin, etc), rather than that of the real v1. The
> > change-id trailer also doesn't match v1.
> > 
> > The actual patch and commit message look fine to me, so:
> 
> Sorry about it, it was totally my mess with b4 on two different
> machines/branches. I've been testing it on a arm64 hosts that
> has no email access. When I picked the patch into the machine with
> email, I messed up where to cherry pick and branches.
>  
> > Acked-by: Mark Rutland <mark.rutland@....com>
> > 
> > I assume that Will or Catalin will be happy to pick this up. I've added
> > those missing folk to this reply, so I don't imagine this should need a
> > respin.
> 
> Thanks. I will not respin then (unless requested).
> 
> Sorry for the mess,

No probs, I'll figure it out!

Will