linux-kernel - Re: [PATCH] gpio: xilinx: convert set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d658a6c5-1d38-455f-8531-9a42a2db2b6f@amd.com>
Date: Thu, 17 Jul 2025 15:16:20 +0200
From: Michal Simek <michal.simek@....com>
To: Bartosz Golaszewski <brgl@...ev.pl>,
 Shubhrajyoti Datta <shubhrajyoti.datta@....com>,
 Srinivas Neeli <srinivas.neeli@....com>,
 Linus Walleij <linus.walleij@...aro.org>
Cc: linux-gpio@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org,
 Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH] gpio: xilinx: convert set_multiple() to the new API as
 well



On 7/17/25 15:11, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> 
> The patch converting the driver to using new GPIO line value setters
> only converted the set() callback and missed set_multiple(). Fix it now.
> 
> Fixes: 1919ea19a4ff ("gpio: xilinx: use new GPIO line value setter callbacks")
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> ---
>   drivers/gpio/gpio-xilinx.c | 8 +++++---
>   1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c
> index aaaa74117980..36d91cacc2d9 100644
> --- a/drivers/gpio/gpio-xilinx.c
> +++ b/drivers/gpio/gpio-xilinx.c
> @@ -175,8 +175,8 @@ static int xgpio_set(struct gpio_chip *gc, unsigned int gpio, int val)
>    * This function writes the specified values into the specified signals of the
>    * GPIO devices.
>    */
> -static void xgpio_set_multiple(struct gpio_chip *gc, unsigned long *mask,
> -			       unsigned long *bits)
> +static int xgpio_set_multiple(struct gpio_chip *gc, unsigned long *mask,
> +			      unsigned long *bits)
>   {
>   	DECLARE_BITMAP(hw_mask, 64);
>   	DECLARE_BITMAP(hw_bits, 64);
> @@ -196,6 +196,8 @@ static void xgpio_set_multiple(struct gpio_chip *gc, unsigned long *mask,
>   	bitmap_copy(chip->state, state, 64);
>   
>   	raw_spin_unlock_irqrestore(&chip->gpio_lock, flags);
> +
> +	return 0;
>   }
>   
>   /**
> @@ -605,7 +607,7 @@ static int xgpio_probe(struct platform_device *pdev)
>   	chip->gc.set_rv = xgpio_set;
>   	chip->gc.request = xgpio_request;
>   	chip->gc.free = xgpio_free;
> -	chip->gc.set_multiple = xgpio_set_multiple;
> +	chip->gc.set_multiple_rv = xgpio_set_multiple;
>   
>   	chip->gc.label = dev_name(dev);
>   

Acked-by: Michal Simek <michal.simek@....com>

Thanks,
Michal