linux-kernel - Re: [PATCH net v2 1/3] bus: fsl-mc: Fix potential double device reference in fsl_mc_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e644p7jtovgm5leuzdw55byf6qzfwbjkjpo4xx3ardhbjkualp@2xbq37yn4mfk>
Date: Thu, 17 Jul 2025 16:15:49 +0300
From: Ioana Ciornei <ioana.ciornei@....com>
To: Ma Ke <make24@...as.ac.cn>
Cc: davem@...emloft.net, andrew+netdev@...n.ch, edumazet@...gle.com, 
	kuba@...nel.org, pabeni@...hat.com, horms@...nel.org, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org, stable@...r.kernel.org
Subject: Re: [PATCH net v2 1/3] bus: fsl-mc: Fix potential double device
 reference in fsl_mc_get_endpoint()

On Thu, Jul 17, 2025 at 10:23:07AM +0800, Ma Ke wrote:
> The fsl_mc_get_endpoint() function may call fsl_mc_device_lookup() 
> twice, which would increment the device's reference count twice if 
> both lookups find a device. This could lead to a reference count leak.
> 
> Found by code review.
> 
> Cc: stable@...r.kernel.org
> Fixes: 1ac210d128ef ("bus: fsl-mc: add the fsl_mc_get_endpoint function")
> Signed-off-by: Ma Ke <make24@...as.ac.cn>

Tested-by: Ioana Ciornei <ioana.ciornei@....com>