linux-kernel - Re: [PATCH 1/3] dt-bindings: mfd: Add power-button option for TI TPS6594 PMIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DBEDT0OKPYAC.EX6HDQCKUWIS@walle.cc>
Date: Thu, 17 Jul 2025 15:58:00 +0200
From: "Michael Walle" <michael@...le.cc>
To: "Job Sava" <jsava@...ticallink.com>, "Krzysztof Kozlowski"
 <krzk@...nel.org>
Cc: "Lee Jones" <lee@...nel.org>, "Rob Herring" <robh@...nel.org>,
 "Krzysztof Kozlowski" <krzk+dt@...nel.org>, "Conor Dooley"
 <conor+dt@...nel.org>, "Julien Panis" <jpanis@...libre.com>, "Dmitry
 Torokhov" <dmitry.torokhov@...il.com>, <devicetree@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, <linux-input@...r.kernel.org>,
 <jcormier@...ticallink.com>
Subject: Re: [PATCH 1/3] dt-bindings: mfd: Add power-button option for TI
 TPS6594 PMIC

Hi,

> > Someone knowing the device should come with arguments whether
> > other states for this are useful at all. Or not useful and then argument
> > that in commit msg for example.
> The other states are not useful for the kernel. Only the push button
> has a need for an interrupt handler. The other states the PMIC handles
> on its own.
>
> What exactly do you want me to change?

Because the driver isn't setting the configuration anyway, wouldn't
it be possible to read the config bits (Register 0x3c, bits 7-6) to
figure out whether the pin is configured as power-button instead of
having this property?

I mean, the correct config is likely stored in the NVM anyway, and
reconfiguring it to another value seems unlikely.

-michael

Download attachment "signature.asc" of type "application/pgp-signature" (298 bytes)