[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <aHqa3HVUjIC7zHAr@tardis.local>
Date: Fri, 18 Jul 2025 12:05:00 -0700
From: Boqun Feng <boqun.feng@...il.com>
To: Alexandre Courbot <acourbot@...dia.com>
Cc: Danilo Krummrich <dakr@...nel.org>, David Airlie <airlied@...il.com>,
Simona Vetter <simona@...ll.ch>,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Maxime Ripard <mripard@...nel.org>,
Thomas Zimmermann <tzimmermann@...e.de>,
Daniel Almeida <daniel.almeida@...labora.com>,
Beata Michalska <beata.michalska@....com>,
nouveau@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 02/19] gpu: nova-core: register: fix typo
On Fri, Jul 18, 2025 at 04:26:07PM +0900, Alexandre Courbot wrote:
> A space was missing between arguments in this invocation.
>
It's obvious up to driver and Nova folks, but I feel this commit better
folded into another patch or we make the title a bit more clear, say:
gpu: nova-core: register: add the missing space in register!()
Otherwise my fear is we're going to end up with a few "fix typo" commits
in the future.
Anyway
Reviewed-by: Boqun Feng <boqun.feng@...il.com>
Regards,
Boqun
> Signed-off-by: Alexandre Courbot <acourbot@...dia.com>
> ---
> drivers/gpu/nova-core/regs/macros.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/nova-core/regs/macros.rs b/drivers/gpu/nova-core/regs/macros.rs
> index 864d1e83bed2979f5661e038f4c9fd87d33f69a7..93e9055d5ebd5f78ea534aafd44d884da0fce345 100644
> --- a/drivers/gpu/nova-core/regs/macros.rs
> +++ b/drivers/gpu/nova-core/regs/macros.rs
> @@ -116,7 +116,7 @@ macro_rules! register {
> ) => {
> register!(@common $name @ $offset $(, $comment)?);
> register!(@field_accessors $name { $($fields)* });
> - register!(@io$name @ + $offset);
> + register!(@io $name @ + $offset);
> };
>
> // Creates a alias register of relative offset register `alias` with its own fields.
>
> --
> 2.50.1
>
>
Powered by blists - more mailing lists