linux-kernel - Re: [PATCH v3] staging: sm750fb: make fixId array static const char * const

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a3813841-7639-4686-98e3-9c43af2dd287@suswa.mountain>
Date: Sat, 19 Jul 2025 00:12:04 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Ignacio Peña <ignacio.pena87@...il.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] staging: sm750fb: make fixId array static const char
 * const

On Fri, Jul 18, 2025 at 04:48:22PM -0400, Ignacio Peña wrote:
> Fix checkpatch warning for the fixId array only:
> "WARNING: static const char * array should probably be
>  static const char * const"
> 
> The g_fbmode array cannot be made const as it is modified at runtime
> in lynxfb_setup() and lynx_alloc().
> 
> Signed-off-by: Ignacio Peña <ignacio.pena87@...il.com>
> ---
> v3: Apologies for the confusion. v2 accidentally included changes to 
>     g_fbmode which breaks the build. This version ONLY changes fixId
>     which is never modified.

Heh.  No.  The patch marked v2 was fine.  Either v2 or this v3 is fine.

Reviewed-by: Dan Carpenter <dan.carpenter@...aro.org>

regards,
dan carpenter