linux-kernel - Re: [PATCH v4] staging: sm750fb: make fixId array static const char * const

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a9cd4eed-841a-4d00-aba3-5ffa0c40c3a7@suswa.mountain>
Date: Sat, 19 Jul 2025 00:17:14 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Ignacio Peña <ignacio.pena87@...il.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] staging: sm750fb: make fixId array static const char
 * const

On Fri, Jul 18, 2025 at 05:08:46PM -0400, Ignacio Peña wrote:
> Fix checkpatch warning for the fixId array only:
> "WARNING: static const char * array should probably be
>  static const char * const"
> 
> The g_fbmode array cannot be made const as it is modified at runtime
> in lynxfb_setup() and lynx_alloc().
> 
> Signed-off-by: Ignacio Peña <ignacio.pena87@...il.com>
> ---
> v4: Sorry for the confusion. Previous versions had wrong line numbers
>     or included changes to g_fbmode. This version ONLY changes fixId
>     at the correct line number (734) against current mainline.

Please stop sending new versions of the patch...  At least wait a day
between sending new versions.  This one was fine already.

No one cares about the line numbers.  You had put that note about line
numbers under the --- cut off line so it's informational only and won't
be included in the final git log.  Also line numbers are constantly
changing so we just ignore it when people tell us they are changing
line 123.  It's not going to be line 123 on our end so it's not helpful.

regards,
dan carpenter