linux-kernel - Re: [PATCH v4] staging: sm750fb: make fixId array static const char * const

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025071951-igloo-stammer-572b@gregkh>
Date: Sat, 19 Jul 2025 08:40:58 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Ignacio Peña <ignacio.pena87@...il.com>
Cc: linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
	Dan Carpenter <dan.carpenter@...aro.org>
Subject: Re: [PATCH v4] staging: sm750fb: make fixId array static const char
 * const

On Fri, Jul 18, 2025 at 05:08:46PM -0400, Ignacio Peña wrote:
> Fix checkpatch warning for the fixId array only:
> "WARNING: static const char * array should probably be
>  static const char * const"
> 
> The g_fbmode array cannot be made const as it is modified at runtime
> in lynxfb_setup() and lynx_alloc().

Why is this part of the changelog at all?  It has no relevance to the
change you are making here.

And as Dan said, please slow down and relax.  There is no rush here at
all.  Take a few days off, think about what you want to do before
resending.

thanks,

greg k-h