linux-kernel - Re: [PATCH] ring-buffer: make the const read-only 'type' static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fab51e17-c1be-494d-8591-3eaf63e3e489@wanadoo.fr>
Date: Sat, 19 Jul 2025 08:32:02 +0200
From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: Masami Hiramatsu <mhiramat@...nel.org>,
 Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
 linux-trace-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
 linux-kernel@...r.kernel.org, Colin Ian King <colin.i.king@...il.com>
Subject: Re: [PATCH] ring-buffer: make the const read-only 'type' static

Le 14/07/2025 à 18:15, Steven Rostedt a écrit :
> On Mon, 14 Jul 2025 17:08:58 +0100
> Colin Ian King <colin.i.king@...il.com> wrote:
> 
>> Don't populate the read-only 'type' on the stack at run time,
>> instead make it static.
> 
> Hmm, why not?
> 
> -- Steve
> 
> 

This is more efficient because there is no need to copy things on the 
stack at run-time.

It also makes binary slightly smaller.

On my x86_64, with allmodconfig:
Before:
======
  229194	 924492	  35104	1188790	 1223b6	kernel/trace/ring_buffer.o

After:
=====
  228873	 924268	  35040	1188181	 122155	kernel/trace/ring_buffer.o

CJ