linux-kernel - Re: [PATCH] ring-buffer: make the const read-only 'type' static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250718222448.13162080@pumpkin>
Date: Fri, 18 Jul 2025 22:24:48 +0100
From: David Laight <david.laight.linux@...il.com>
To: Colin Ian King <colin.i.king@...il.com>
Cc: Steven Rostedt <rostedt@...dmis.org>, Masami Hiramatsu
 <mhiramat@...nel.org>, Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
 linux-trace-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ring-buffer: make the const read-only 'type' static

On Mon, 14 Jul 2025 17:08:58 +0100
Colin Ian King <colin.i.king@...il.com> wrote:

> Don't populate the read-only 'type' on the stack at run time,
> instead make it static.
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> ---
>  kernel/trace/ring_buffer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
> index 00fc38d70e86..39aa1f50274f 100644
> --- a/kernel/trace/ring_buffer.c
> +++ b/kernel/trace/ring_buffer.c
> @@ -4118,7 +4118,7 @@ EXPORT_SYMBOL_GPL(ring_buffer_unlock_commit);
>  
>  static const char *show_irq_str(int bits)
>  {
> -	const char *type[] = {
> +	static const char * type[] = {

Better would be:
	static const char type[][4] = {

  David

>  		".",	// 0
>  		"s",	// 1
>  		"h",	// 2