linux-kernel - Re: [PATCH 10/10] ASoC: dt-bindings: mediatek,mt8189-nau8825: add mt8189-nau8825 document

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9f752338a2deda3e3475468ccc881230dc370f88.camel@mediatek.com>
Date: Fri, 18 Jul 2025 08:48:16 +0000
From: Cyril Chao (钞悦) <Cyril.Chao@...iatek.com>
To: "krzk@...nel.org" <krzk@...nel.org>, "broonie@...nel.org"
	<broonie@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
	"tiwai@...e.com" <tiwai@...e.com>, "robh@...nel.org" <robh@...nel.org>,
	"lgirdwood@...il.com" <lgirdwood@...il.com>, "matthias.bgg@...il.com"
	<matthias.bgg@...il.com>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
	"perex@...ex.cz" <perex@...ex.cz>, AngeloGioacchino Del Regno
	<angelogioacchino.delregno@...labora.com>
CC: "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-mediatek@...ts.infradead.org"
	<linux-mediatek@...ts.infradead.org>, "linux-sound@...r.kernel.org"
	<linux-sound@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, Project_Global_Chrome_Upstream_Group
	<Project_Global_Chrome_Upstream_Group@...iatek.com>
Subject: Re: [PATCH 10/10] ASoC: dt-bindings: mediatek,mt8189-nau8825: add
 mt8189-nau8825 document

On Sat, 2025-06-28 at 14:42 +0200, Krzysztof Kozlowski wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On 28/06/2025 09:14, Cyril wrote:
> > From: Cyril Chao <Cyril.Chao@...iatek.com>
> > 
> > Add document for mt8189 board with nau8825.
> > 
> > Signed-off-by: Cyril Chao <Cyril.Chao@...iatek.com>
> 
> Why does the binding come after user? Follow submitting patches in
> DT.
> 
Could you help to clarify this? Is it the order in which I submitted
the dt-binding patch that's incorrect? Much thanks~~

> > ---
> >  .../sound/mediatek,mt8189-nau8825.yaml        | 103
> > ++++++++++++++++++
> >  1 file changed, 103 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/sound/mediatek,mt8189-
> > nau8825.yaml
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/sound/mediatek,mt8189-
> > nau8825.yaml
> > b/Documentation/devicetree/bindings/sound/mediatek,mt8189-
> > nau8825.yaml
> > new file mode 100644
> > index 000000000..331c537d3
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/sound/mediatek,mt8189-
> > nau8825.yaml
> > @@ -0,0 +1,103 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: 
> > https://urldefense.com/v3/__http://devicetree.org/schemas/sound/mediatek,mt8189-nau8825.yaml*__;Iw!!CTRNKA9wMg0ARbw!j89p8C_6FDSbTlAEyYXTN2T5R6NmwjSwuhNHbIBLbbCRLSUqEWDlBy-FlOeo8rxCTSJeuH6BLVZS00w$
> > +$schema: 
> > https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!CTRNKA9wMg0ARbw!j89p8C_6FDSbTlAEyYXTN2T5R6NmwjSwuhNHbIBLbbCRLSUqEWDlBy-FlOeo8rxCTSJeuH6BzAjmYYE$
> > +
> > +title: MediaTek MT8189 ASoC sound card
> > +
> > +maintainers:
> > +  - Darren Ye <darren.ye@...iatek.com>
> > +  - Cyril Chao <cyril.chao@...iatek.com>
> > +
> > +allOf:
> > +  - $ref: sound-card-common.yaml#
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - mediatek,mt8189-nau8825-sound
> > +      - mediatek,mt8189-rt5650-sound
> > +      - mediatek,mt8189-rt5682s-sound
> > +      - mediatek,mt8189-rt5682i-sound
> 
> Sound is redundant. Can it be anything else?
> 
Okay, I will remove 'sound' next version, and like this:
mediatek,mt8189-nau8825
mediatek,mt8189-rt5650
mediatek,mt8189-rt5682s
mediatek,mt8189-rt5682i

Thanks for review~~~

Best Regards
Cyril Chao

> 
> Best regards,
> Krzysztof