[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <9a932904-4aec-4e2d-b00f-519a4ca92e17@kernel.org>
Date: Fri, 18 Jul 2025 11:18:57 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Cyril Chao (钞悦) <Cyril.Chao@...iatek.com>,
"broonie@...nel.org" <broonie@...nel.org>,
"conor+dt@...nel.org" <conor+dt@...nel.org>, "tiwai@...e.com"
<tiwai@...e.com>, "robh@...nel.org" <robh@...nel.org>,
"lgirdwood@...il.com" <lgirdwood@...il.com>,
"matthias.bgg@...il.com" <matthias.bgg@...il.com>,
"krzk+dt@...nel.org" <krzk+dt@...nel.org>, "perex@...ex.cz"
<perex@...ex.cz>,
AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Cc: "linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
"linux-sound@...r.kernel.org" <linux-sound@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
Project_Global_Chrome_Upstream_Group
<Project_Global_Chrome_Upstream_Group@...iatek.com>
Subject: Re: [PATCH 09/10] ASoC: mediatek: mt8189: add machine driver with
nau8825
On 18/07/2025 10:44, Cyril Chao (钞悦) wrote:
> On Sat, 2025-06-28 at 14:39 +0200, Krzysztof Kozlowski wrote:
>>> + .of_match_table = mt8189_nau8825_dt_match,
>>> +#endif
>>> + .pm = &snd_soc_pm_ops,
>>> + },
>>> + .probe = mtk_soundcard_common_probe,
>>> +};
>>> +
>>> +module_platform_driver(mt8189_nau8825_driver);
>>> +
>>> +/* Module information */
>>> +MODULE_DESCRIPTION("MT8189 NAU8825 ALSA SoC machine driver");
>>> +MODULE_AUTHOR("Darren Ye <darren.ye@...iatek.com>");
>>> +MODULE_LICENSE("GPL");
>>> +MODULE_ALIAS("mt8189 nau8825 soc card");
>>
>> That's neither needed nor correct. Look how aliases are created
>> first.
>
> I reffered to the previous platform(mt8188). Could you help to give an
> example about MODULE_ALIAS or some doc for me to reffer? Much thanks ~~
If you ask for doc, then it feels like you do not know if you need it. I
think you do not need it and the burden of proving why you need it is on
you.
Best regards,
Krzysztof
Powered by blists - more mailing lists