linux-kernel - Re: x86/apic: Drop useless CXL/CPX row from the TSC deadline errata table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a6d7becc-9971-4e35-982a-3e35af4c4666@citrix.com>
Date: Fri, 18 Jul 2025 11:43:47 +0100
From: Andrew Cooper <andrew.cooper3@...rix.com>
To: Sohil Mehta <sohil.mehta@...el.com>
Cc: Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
 Borislav Petkov <bp@...en8.de>, Dave Hansen <dave.hansen@...ux.intel.com>,
 x86@...nel.org, "H. Peter Anvin" <hpa@...or.com>,
 Peter Zijlstra <peterz@...radead.org>, Yuntao Wang <yuntao.wang@...ux.dev>,
 Zhang Rui <rui.zhang@...el.com>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: x86/apic: Drop useless CXL/CPX row from the TSC deadline errata
 table

On 17/07/2025 9:25 pm, Sohil Mehta wrote:
> On 7/16/2025 9:08 AM, Andrew Cooper wrote:
>> A microcode revision of 0 is guaranteed to exit apic_validate_deadline_timer()
>> early, but a better way is with no row at all.
>>
> Yeah, not having an entry is much better. "exit" can be a bit ambiguous.
> Should we be slightly more precise?

It's "exit $foo early", although this is slightly hidden by the linebreak.

Alternatively, it could be phrased as "exit early from $foo" if you
think that's clearer?

>
> A microcode revision of 0 is guaranteed to return true for
> apic_validate_deadline_timer(), but a better way is with no row at all.
>
>> No functional change.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@...rix.com>
>> ---
> Reviewed-by: Sohil Mehta <sohil.mehta@...el.com>

Thanks.

~Andrew