linux-kernel - Re: [PATCH v3] staging: rtl8192u: Rename ChannelPlan to channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6c0d6a6e-4b47-48c9-acbd-b5dd33fd0001@suswa.mountain>
Date: Fri, 18 Jul 2025 05:02:42 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Vivek BalachandharTN <vivek.balachandhar@...il.com>
Cc: gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
	linux-staging@...ts.linux.dev
Subject: Re: [PATCH v3] staging: rtl8192u: Rename ChannelPlan to channel_plan
 and fix index name

The rtl8192u driver was removed.  Work against the current code.  (Just
use linux-next probably).

On Fri, Jul 18, 2025 at 01:55:25AM +0000, Vivek BalachandharTN wrote:
> This patch renames the global array ChannelPlan to channel_plan
> to follow Linux kernel coding style. Also renamed the index
> variable from channel_plan to chan_plan_idx to avoid
> shadowing and improve readability.
> 
> v2:
> - Fixed Cc list to include Greg and staging list
> 
> v3:
> - Removed EXTRAVERSION = -vivek from Makefile.

Heh.  No.  Still there.  Slow down, there is no rush.  Let people
review the rest and see if there is anything else to change.

> @@ -145,12 +145,12 @@ static struct CHANNEL_LIST ChannelPlan[] = {
>  	{{1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14}, 14}
>  };
>  
> -static void rtl819x_set_channel_map(u8 channel_plan, struct r8192_priv *priv)
> +static void rtl819x_set_channel_map(u8 chan_plan_idx, struct r8192_priv *priv)

I hate the name chan_plan_idx.  Probably "chan" would have been a better
name.

>  {
>  	int i, max_chan = -1, min_chan = -1;
>  	struct ieee80211_device *ieee = priv->ieee80211;
>  
> -	switch (channel_plan) {
> +	switch (chan_plan_idx) {
> diff --git a/init/main.c b/init/main.c
> index aa21add5f..648589720 100644
> --- a/init/main.c
> +++ b/init/main.c
> @@ -680,6 +680,7 @@ static void __init setup_command_line(char *command_line)
>  
>  static __initdata DECLARE_COMPLETION(kthreadd_done);
>  
> +

This change is a mistake as well.

>  noinline void __ref rest_init(void)
>  {
>  	struct task_struct *tsk;

regards,
dan carpenter