linux-kernel - Re: [PATCH] mtd: spi-nor: winbond: Add support for W77Q51NW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ada14a84-0b98-485b-bd84-26666f7a9b3b@mailbox.org>
Date: Mon, 21 Jul 2025 22:34:28 +0200
From: Marek Vasut <marek.vasut@...lbox.org>
To: Tudor Ambarus <tudor.ambarus@...aro.org>,
 Marek Vasut <marek.vasut+renesas@...lbox.org>, linux-mtd@...ts.infradead.org
Cc: Michael Walle <mwalle@...nel.org>,
 Miquel Raynal <miquel.raynal@...tlin.com>,
 Pratyush Yadav <pratyush@...nel.org>, Richard Weinberger <richard@....at>,
 Vignesh Raghavendra <vigneshr@...com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mtd: spi-nor: winbond: Add support for W77Q51NW

On 7/21/25 11:28 AM, Tudor Ambarus wrote:

Hi,

>> diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
>> index 63a93c9eb917..dcb6c9ec862a 100644
>> --- a/drivers/mtd/spi-nor/winbond.c
>> +++ b/drivers/mtd/spi-nor/winbond.c
>> @@ -343,6 +343,10 @@ static const struct flash_info winbond_nor_parts[] = {
>>   		.id = SNOR_ID(0xef, 0x80, 0x20),
>>   		.name = "w25q512nwm",
>>   		.otp = SNOR_OTP(256, 3, 0x1000, 0x1000),
>> +	}, {
>> +		.id = SNOR_ID(0xef, 0x8a, 0x1a),
>> +		.name = "w77q51nw",
> 
> we concluded that the name is not relevant, as there can be flashes
> that update their name or worse, entirely different flashes that use
> the same flash ID. So please add the name as a comment, above the flash
> definition. See recent flash additions.
> 
> Also, we introduced some minimum testing requirements, so that we make
> sure that the flash was tested at the time of submission and also to
> save the dtb database in case other flashes reuse the flash ID, or
> different flavors appear, etc. Please do the tests described at:
> https://docs.kernel.org/driver-api/mtd/spi-nor.html#minimum-testing-requirements
Should all be part of V2 I just posted, thanks .