linux-kernel - Re: [PATCH] mtd: spi-nor: winbond: Add support for W77Q51NW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <11349679-f1c4-4648-83ec-2292f1c2ae3f@linaro.org>
Date: Mon, 21 Jul 2025 10:28:30 +0100
From: Tudor Ambarus <tudor.ambarus@...aro.org>
To: Marek Vasut <marek.vasut+renesas@...lbox.org>,
 linux-mtd@...ts.infradead.org
Cc: Michael Walle <mwalle@...nel.org>,
 Miquel Raynal <miquel.raynal@...tlin.com>,
 Pratyush Yadav <pratyush@...nel.org>, Richard Weinberger <richard@....at>,
 Vignesh Raghavendra <vigneshr@...com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mtd: spi-nor: winbond: Add support for W77Q51NW

hiya, Marek,

On 7/20/25 8:55 PM, Marek Vasut wrote:
> Add IDs for Winbond W77Q51NW, 512M-bit Secure Serial Flash Memory
> with Post-Quantum Cryptography, Dual/Quad SPI, QPI and DTR . The
> flash part is similar to W25Q512NWM .
> 
> Signed-off-by: Marek Vasut <marek.vasut+renesas@...lbox.org>
> ---
> Cc: Michael Walle <mwalle@...nel.org>
> Cc: Miquel Raynal <miquel.raynal@...tlin.com>
> Cc: Pratyush Yadav <pratyush@...nel.org>
> Cc: Richard Weinberger <richard@....at>
> Cc: Tudor Ambarus <tudor.ambarus@...aro.org>
> Cc: Vignesh Raghavendra <vigneshr@...com>
> Cc: linux-kernel@...r.kernel.org
> Cc: linux-mtd@...ts.infradead.org
> ---
>  drivers/mtd/spi-nor/winbond.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
> index 63a93c9eb917..dcb6c9ec862a 100644
> --- a/drivers/mtd/spi-nor/winbond.c
> +++ b/drivers/mtd/spi-nor/winbond.c
> @@ -343,6 +343,10 @@ static const struct flash_info winbond_nor_parts[] = {
>  		.id = SNOR_ID(0xef, 0x80, 0x20),
>  		.name = "w25q512nwm",
>  		.otp = SNOR_OTP(256, 3, 0x1000, 0x1000),
> +	}, {
> +		.id = SNOR_ID(0xef, 0x8a, 0x1a),
> +		.name = "w77q51nw",

we concluded that the name is not relevant, as there can be flashes
that update their name or worse, entirely different flashes that use
the same flash ID. So please add the name as a comment, above the flash
definition. See recent flash additions.

Also, we introduced some minimum testing requirements, so that we make
sure that the flash was tested at the time of submission and also to
save the dtb database in case other flashes reuse the flash ID, or
different flavors appear, etc. Please do the tests described at:
https://docs.kernel.org/driver-api/mtd/spi-nor.html#minimum-testing-requirements

Cheers,
ta


> +		.otp = SNOR_OTP(256, 3, 0x1000, 0x1000),
>  	},
>  };
>