linux-kernel - Re: [PATCH 2/9] arm64: dts: exynosautov920: add abox

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b5da2e57-6135-433e-ad92-0bd2fa71458e@kernel.org>
Date: Mon, 21 Jul 2025 08:41:13 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: ew kim <ew.kim@...sung.com>, broonie@...nel.org, s.nawrocki@...sung.com,
 robh@...nel.org, krzk+dt@...nel.org
Cc: lgirdwood@...il.com, tiwai@...e.com, perex@...ex.cz, conor+dt@...nel.org,
 alim.akhtar@...sung.com, linux-sound@...r.kernel.org,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/9] arm64: dts: exynosautov920: add abox_generic dt node

On 21/07/2025 04:30, ew kim wrote:
> Add device tree node for the abox_generic platform driver to enable
> its registration as a platform device. This node does not represent
> direct hardware resources but is necessary for driver initialization
> and platform device binding.
> 
> Properties added in the device tree node:
> 
> - samsung,num-pcm-playback (uint32):
>   Maximum number of supported PCM playback devices.
>   Here, PCM playback devices refer to ALSA PCM devices.
> 
> - samsung,num-pcm-capture (uint32):
>   Maximum number of supported PCM capture devices.
>   Here, PCM capture devices refer to ALSA PCM devices.
> 
> - samsung,num-i2s-dummy-backend (uint32):
>   Maximum number of supported I2S dummy backend devices.
> 
> The node is declared disabled by default in the main device tree source,
> and enabled via board-specific DTS overlays by setting status = "okay".
> 
> This device tree binding document will be added under
> Documentation/devicetree/bindings/sound/samsung,exynosauto.yaml
> 
> to describe the node properties and usage.
> 
> Signed-off-by: ew kim <ew.kim@...sung.com>
> ---
>  arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts |  4 ++++
>  arch/arm64/boot/dts/exynos/exynosautov920.dtsi     | 10 ++++++++++

Entirely wrong order of patches.

>  2 files changed, 14 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts b/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
> index a397f068ed53..a870c0b6847f 100644
> --- a/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
> +++ b/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
> @@ -86,3 +86,7 @@ &usi_0 {
>  &xtcxo {
>  	clock-frequency = <38400000>;
>  };
> +
> +&abox_generic {
> +	status = "okay";
> +};
> \ No newline at end of file


?

> diff --git a/arch/arm64/boot/dts/exynos/exynosautov920.dtsi b/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
> index 2cb8041c8a9f..4f086a7a79c8 100644
> --- a/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
> @@ -1126,6 +1126,16 @@ timer {
>  			     <GIC_PPI 10 IRQ_TYPE_LEVEL_LOW>,
>  			     <GIC_PPI 12 IRQ_TYPE_LEVEL_LOW>;
>  	};
> +
> +	abox_generic: abox_generic {


And you did not resolve any of previous comments, just sent the same v1.

NAK.

Implement and respond to feedback. Then version properly your patches.



Best regards,
Krzysztof