linux-kernel - Re: [PATCH 5/9] arm64: dts: exynosautov920: Add ABOX IPC Generic device node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9ae13771-e577-4005-84cd-230aba048085@kernel.org>
Date: Mon, 21 Jul 2025 08:45:59 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: ew kim <ew.kim@...sung.com>, broonie@...nel.org, s.nawrocki@...sung.com,
 robh@...nel.org, krzk+dt@...nel.org
Cc: lgirdwood@...il.com, tiwai@...e.com, perex@...ex.cz, conor+dt@...nel.org,
 alim.akhtar@...sung.com, linux-sound@...r.kernel.org,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/9] arm64: dts: exynosautov920: Add ABOX IPC Generic
 device node

On 21/07/2025 04:30, ew kim wrote:
> This patch adds a new child node `abox_ipc_generic` under the

Please read kernel submitting patches and DT bindings submitting patches.

> `abox_generic` node for ExynosAuto v920. The ABOX IPC Generic
> driver handles inter-processor communication (IPC) between
> the ABOX DSP and host SoC using IRQs.
> 
> The node includes configuration for the number of IRQ channels
> used for IPC routing. This allows SoC-specific subsystems to
> send and receive messages through the ABOX generic audio stack.
> 
> Signed-off-by: ew kim <ew.kim@...sung.com>
> ---
>  arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts |  6 +++++-
>  arch/arm64/boot/dts/exynos/exynosautov920.dtsi     | 10 ++++++++--
>  2 files changed, 13 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts b/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
> index a870c0b6847f..2f4cf112675a 100644
> --- a/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
> +++ b/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
> @@ -89,4 +89,8 @@ &xtcxo {
>  
>  &abox_generic {
>  	status = "okay";
> -};
> \ No newline at end of file
> +};
> +
> +&abox_ipc_generic {
> +	status = "okay";
> +};
> diff --git a/arch/arm64/boot/dts/exynos/exynosautov920.dtsi b/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
> index 4f086a7a79c8..21bcbcf7e2b6 100644
> --- a/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynosautov920.dtsi
> @@ -1133,8 +1133,14 @@ abox_generic: abox_generic {
>  		samsung,num-pcm-capture = <32>;
>  		samsung,num-i2s-dummy-backend = <5>;
>  		status = "disabled";
> -		#address-cells = <2>;
> -		#size-cells = <1>;
> +		/* #address-cells = <2>; */
> +		/* #size-cells = <1>; */
> +
> +		abox_ipc_generic: abox_ipc_generic {
> +			compatible = "samsung,abox_ipc_generic";

No bindings. Are you sure you follow standard patchset order?

Best regards,
Krzysztof