linux-kernel - Re: [PATCH 6/9] ASoC : dt-bindings: sound: Add binding for ABOX IPC Generic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <856f876d-c6f2-4968-81ea-2e9ccaba879a@kernel.org>
Date: Mon, 21 Jul 2025 08:46:29 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: ew kim <ew.kim@...sung.com>, broonie@...nel.org, s.nawrocki@...sung.com,
 robh@...nel.org, krzk+dt@...nel.org
Cc: lgirdwood@...il.com, tiwai@...e.com, perex@...ex.cz, conor+dt@...nel.org,
 alim.akhtar@...sung.com, linux-sound@...r.kernel.org,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/9] ASoC : dt-bindings: sound: Add binding for ABOX IPC
 Generic

On 21/07/2025 04:30, ew kim wrote:
> This patch updates the existing samsung,exynosauto.yaml schema to
> describe the ABOX IPC Generic child node. This node represents
> a virtual IPC interface used by the ABOX audio subsystem to
> communicate with SoC-specific hardware using shared IRQ channels.
> 
> The schema describes the `samsung,num-irq` property and allows
> integration of the IPC node under `abox_generic`.
> 
> Signed-off-by: ew kim <ew.kim@...sung.com>
> ---
>  .../bindings/sound/samsung,exynosauto.yaml    | 23 +++++++++++++++++++
>  1 file changed, 23 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/samsung,exynosauto.yaml b/Documentation/devicetree/bindings/sound/samsung,exynosauto.yaml
> index b1e49f38ffe9..3a7b5be627ee 100644
> --- a/Documentation/devicetree/bindings/sound/samsung,exynosauto.yaml
> +++ b/Documentation/devicetree/bindings/sound/samsung,exynosauto.yaml
> @@ -48,6 +48,23 @@ properties:
>      description: Required for child nodes that may declare address space.
>      const: 1
>  
> +  abox_ipc_generic:
> +    type: object
> +    description: ABOX IPC Generic subnode for SoC-level message routing
> +    properties:
> +      compatible:
> +        const: samsung,abox_ipc_generic

We cannot take generic IPC.
> +
> +      samsung,num-irq:
> +        $ref: /schemas/types.yaml#/definitions/uint32
> +        description: Number of IRQ channels supported for IPC routing.
> +
> +    required:
> +      - compatible
> +      - samsung,num-irq
> +
> +    additionalProperties: false
> +
>  required:
>    - compatible
>    - samsung,num-pcm-playback
> @@ -66,4 +83,10 @@ examples:
>        status = "disabled";
>        #address-cells = <2>;
>        #size-cells = <1>;
> +
> +      abox_ipc_generic {
> +        compatible = "samsung,abox_ipc_generic";
> +        samsung,num-irq = <64>;
> +        status = "disabled";

So you never test it...

> +      };
>      };


Best regards,
Krzysztof