linux-kernel - Re: [PATCH 9/9] ASoC: dt-bindings: sound: exynosauto: add PCM frontend nodes for ABOX generic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2b6481e8-9a70-4676-bca4-da3ee00e73ba@kernel.org>
Date: Mon, 21 Jul 2025 08:47:35 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: ew kim <ew.kim@...sung.com>, broonie@...nel.org, s.nawrocki@...sung.com,
 robh@...nel.org, krzk+dt@...nel.org
Cc: lgirdwood@...il.com, tiwai@...e.com, perex@...ex.cz, conor+dt@...nel.org,
 alim.akhtar@...sung.com, linux-sound@...r.kernel.org,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 9/9] ASoC: dt-bindings: sound: exynosauto: add PCM
 frontend nodes for ABOX generic

On 21/07/2025 04:30, ew kim wrote:
> This patch extends the Exynos Automotive ABOX generic device tree bindings
> to support PCM playback and capture frontend nodes.
> 
> Each PCM device node describes an audio stream interface handled by the
> ABOX DSP. These nodes include properties for stream ID, IRQ, ADSP core
> assignment, buffer limits, and stream category (deep_buffer or compress).
> 
> The bindings use patternProperties to match playback and capture nodes
> as children of the abox_generic controller.

This split of one device into three makes no sense. Adding new binding
is one commit.

> 
> Signed-off-by: ew kim <ew.kim@...sung.com>
> ---
>  .../bindings/sound/samsung,exynosauto.yaml    | 126 +++++++++++++++++-
>  1 file changed, 123 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/sound/samsung,exynosauto.yaml b/Documentation/devicetree/bindings/sound/samsung,exynosauto.yaml
> index 3a7b5be627ee..e477550afc7c 100644
> --- a/Documentation/devicetree/bindings/sound/samsung,exynosauto.yaml
> +++ b/Documentation/devicetree/bindings/sound/samsung,exynosauto.yaml
> @@ -28,6 +28,14 @@ properties:
>    compatible:
>      const: samsung,abox_generic
>  
> +  status:
> +    enum: [ okay, disabled ]
> +    description: DTS node enablement state


Sorry, but why are you writing something entirely different than every
other binding?


Best regards,
Krzysztof