linux-kernel - Re: [PATCH] fs: Add additional checks for block devices during mount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250721064712.GA28899@lst.de>
Date: Mon, 21 Jul 2025 08:47:12 +0200
From: Christoph Hellwig <hch@....de>
To: Zizhi Wo <wozizhi@...weicloud.com>
Cc: kernel test robot <lkp@...el.com>, viro@...iv.linux.org.uk,
	jack@...e.com, brauner@...nel.org, axboe@...nel.dk, hch@....de,
	llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	yukuai3@...wei.com, yangerkun@...wei.com
Subject: Re: [PATCH] fs: Add additional checks for block devices during
 mount

On Mon, Jul 21, 2025 at 09:20:27AM +0800, Zizhi Wo wrote:
> Sorry, disk_live() is only declared but not defined when CONFIG_BLOCK is
> not set...

You can just add a if (IS_ENABLED(CONFIG_BLOCK)) check around it.


But the layering here feels wrong.  sget_dev and it's helper operate
purely on the dev_t.  Anything actually dealing with a block device /
gendisk should be in the helpers that otherwise use it.