linux-kernel - Re: [PATCH v5 2/3] dt-bindings: leds: issi,is31fl3236: add support for is31fl3236a

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c4e4f79b-5b1d-4cab-a8f0-49adbe30f2af@kernel.org>
Date: Mon, 21 Jul 2025 13:16:59 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Pawel Zalewski <pzalewski@...goodpenguin.co.uk>,
 Lee Jones <lee@...nel.org>, Pavel Machek <pavel@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>
Cc: linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org,
 Pavel Machek <pavel@....cz>, devicetree@...r.kernel.org
Subject: Re: [PATCH v5 2/3] dt-bindings: leds: issi,is31fl3236: add support
 for is31fl3236a

On 21/07/2025 12:55, Pawel Zalewski wrote:
> Add an additional and optional control property for setting
> the output PWM frequency to 22kHz that exists on is31fl3236a.
> The default is 3kHz and this option puts the operational frequency
> outside of the audible range.
> 
> Signed-off-by: Pawel Zalewski <pzalewski@...goodpenguin.co.uk>
> ---
>  .../devicetree/bindings/leds/issi,is31fl3236.yaml  | 24 ++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/leds/issi,is31fl3236.yaml b/Documentation/devicetree/bindings/leds/issi,is31fl3236.yaml
> index d8164876611f5e629215fe2715ebff1745f93a26..58f5aa4d0b644fe550e2c48b141c41c37fdf98e9 100644
> --- a/Documentation/devicetree/bindings/leds/issi,is31fl3236.yaml
> +++ b/Documentation/devicetree/bindings/leds/issi,is31fl3236.yaml
> @@ -17,6 +17,7 @@ description: |
>  
>    For more product information please see the links below:
>      https://www.lumissil.com/assets/pdf/core/IS31FL3236_DS.pdf
> +    https://www.lumissil.com/assets/pdf/core/IS31FL3236A_DS.pdf
>      https://www.lumissil.com/assets/pdf/core/IS31FL3235_DS.pdf
>      https://www.lumissil.com/assets/pdf/core/IS31FL3218_DS.pdf
>      https://www.lumissil.com/assets/pdf/core/IS31FL3216_DS.pdf
> @@ -25,6 +26,7 @@ properties:
>    compatible:
>      enum:
>        - issi,is31fl3236
> +      - issi,is31fl3236a
>        - issi,is31fl3235
>        - issi,is31fl3218
>        - issi,is31fl3216
> @@ -40,6 +42,12 @@ properties:
>    "#size-cells":
>      const: 0
>  
> +  issi,22kHz-pwm:

I never spotted it before, but this should be issi,22khz-pwm. No
properties use capital letters.

> +    type: boolean
> +    description:
> +      When present, the chip's PWM will operate at ~22kHz as opposed
> +      to ~3kHz to move the operating frequency out of the audible range.
> +


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>


Best regards,
Krzysztof