linux-kernel - Re: [PATCH v5 1/3] dt-bindings: leds: is31fl32xx: convert the binding to yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4f57cca8-49a8-4431-b41c-78097eb11da9@kernel.org>
Date: Mon, 21 Jul 2025 13:16:46 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Pawel Zalewski <pzalewski@...goodpenguin.co.uk>,
 Lee Jones <lee@...nel.org>, Pavel Machek <pavel@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>
Cc: linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org,
 Pavel Machek <pavel@....cz>, devicetree@...r.kernel.org,
 Lucca Fachinetti <luccafachinetti@...il.com>
Subject: Re: [PATCH v5 1/3] dt-bindings: leds: is31fl32xx: convert the binding
 to yaml

On 21/07/2025 12:55, Pawel Zalewski wrote:
> +
> +properties:
> +  compatible:
> +    enum:
> +      - issi,is31fl3236
> +      - issi,is31fl3235
> +      - issi,is31fl3218
> +      - issi,is31fl3216

Keep alphabetical order.

> +      - si-en,sn3218
> +      - si-en,sn3216

Here as well.


> +
> +  reg:
> +    maxItems: 1
> +
> +  "#address-cells":
> +    const: 1
> +
> +  "#size-cells":
> +    const: 0
> +
> +patternProperties:
> +  "^led@[1-9a-f][0-9a-f]*$":

This still does not match min/max constraints. You already got the
comment on this and nothing improved.

> +    type: object
> +    $ref: common.yaml#
> +    unevaluatedProperties: false
> +
> +    properties:
> +      reg:
> +        description:
> +          LED channel number (1..N)
> +        minimum: 0x1
> +        maximum: 0x24

And these are supposed to be decimal.


Best regards,
Krzysztof