[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e0777d1d-8e69-495b-8067-9f4896b2b845@sirena.org.uk>
Date: Mon, 21 Jul 2025 13:00:45 +0100
From: Mark Brown <broonie@...nel.org>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Joy Zou <joy.zou@....com>, Liam Girdwood <lgirdwood@...il.com>,
Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, linux-kernel@...r.kernel.org,
devicetree@...r.kernel.org, imx@...ts.linux.dev,
Frank Li <Frank.Li@....com>, Ye Li <ye.li@....com>,
Jacky Bai <ping.bai@....com>, Dong Aisheng <aisheng.dong@....com>
Subject: Re: [PATCH v2 1/2] dt-bindings: regulator: add PF0900 regulator yaml
On Mon, Jul 21, 2025 at 09:28:59AM +0200, Krzysztof Kozlowski wrote:
> > + nxp,i2c-crc-enable:
> > + type: boolean
> > + description: If the PMIC OTP_I2C_CRC_EN is enable, you need to add this property.
> 1. Why you cannot just read registers to check for this?
> 2. You need anyway proper description what is this about and then wrap
> according to Linux coding style.
Looking at the driver code the CRCs are also done on reads as well.
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists