linux-kernel - Re: [PATCH v2 2/2] regulator: pf0900: Add PMIC PF0900 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6e3d022c-daec-4c3f-b064-33abdd7e2c93@sirena.org.uk>
Date: Mon, 21 Jul 2025 13:26:00 +0100
From: Mark Brown <broonie@...nel.org>
To: Joy Zou <joy.zou@....com>
Cc: Liam Girdwood <lgirdwood@...il.com>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org, imx@...ts.linux.dev,
	Frank Li <Frank.Li@....com>, Ye Li <ye.li@....com>,
	Jacky Bai <ping.bai@....com>, Dong Aisheng <aisheng.dong@....com>,
	kernel test robot <lkp@...el.com>
Subject: Re: [PATCH v2 2/2] regulator: pf0900: Add PMIC PF0900 support

On Mon, Jul 21, 2025 at 03:11:28PM +0800, Joy Zou wrote:

> The PF0900 is a power management integrated circuit (PMIC) optimized
> for high performance i.MX9x based applications. It features five high
> efficiency buck converters, three linear and one vaon regulators.
> It provides low quiescent current in Standby and low power off Modes.

This looks basically fine, one very minor issue since it looks like you
need to resubmit for the bindings:

> +static const struct regmap_config pf0900_regmap_config = {
> +	.reg_bits = 8,
> +	.val_bits = 8,
> +	.volatile_table = &pf0900_volatile_regs,
> +	.max_register = PF0900_MAX_REGISTER - 1,
> +	.cache_type = REGCACHE_RBTREE,
> +};

Unless you've got a strong reason to do something else new drivers
should use _MAPLE, it's a more modern data structure.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)