[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <989a77d1-334c-444b-b6fd-3c0680a2f035@nvidia.com>
Date: Tue, 22 Jul 2025 08:23:35 +0300
From: Yonatan Maman <ymaman@...dia.com>
To: Christoph Hellwig <hch@...radead.org>
Cc: Jérôme Glisse <jglisse@...hat.com>,
Andrew Morton <akpm@...ux-foundation.org>, Jason Gunthorpe <jgg@...pe.ca>,
Leon Romanovsky <leon@...nel.org>, Lyude Paul <lyude@...hat.com>,
Danilo Krummrich <dakr@...nel.org>, David Airlie <airlied@...il.com>,
Simona Vetter <simona@...ll.ch>, Alistair Popple <apopple@...dia.com>,
Ben Skeggs <bskeggs@...dia.com>, Michael Guralnik <michaelgur@...dia.com>,
Or Har-Toov <ohartoov@...dia.com>, Daisuke Matsuda <dskmtsd@...il.com>,
Shay Drory <shayd@...dia.com>, linux-mm@...ck.org,
linux-rdma@...r.kernel.org, dri-devel@...ts.freedesktop.org,
nouveau@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
Gal Shalom <GalShalom@...dia.com>
Subject: Re: [PATCH v2 2/5] nouveau/dmem: HMM P2P DMA for private dev pages
On 21/07/2025 10:00, Christoph Hellwig wrote:
> On Fri, Jul 18, 2025 at 02:51:09PM +0300, Yonatan Maman wrote:
>> + .get_dma_pfn_for_device = nouveau_dmem_get_dma_pfn,
>
> Please don't shorten the method name prefix in the implementation
> symbol name, as that makes reading / refactoring the code a pain.
>
> This might also be a hint that your method name is too long.
>
got it, will be fixed in V3, thanks.
Powered by blists - more mailing lists