linux-kernel - Re: [PATCH v5 3/8] dt-bindings: regulator: Document MediaTek MT6363 PMIC Regulators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGXv+5Eajtt17rp2qGDDi6-Xvj6cxmhJBHjhp_XLDaX90WiNFg@mail.gmail.com>
Date: Tue, 22 Jul 2025 13:24:19 +0800
From: Chen-Yu Tsai <wenst@...omium.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Cc: Rob Herring <robh@...nel.org>, linux-mediatek@...ts.infradead.org, lee@...nel.org, 
	krzk+dt@...nel.org, conor+dt@...nel.org, matthias.bgg@...il.com, 
	lgirdwood@...il.com, broonie@...nel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	kernel@...labora.com
Subject: Re: [PATCH v5 3/8] dt-bindings: regulator: Document MediaTek MT6363
 PMIC Regulators

On Thu, Jul 17, 2025 at 11:29 PM Rob Herring <robh@...nel.org> wrote:
>
> On Tue, Jul 15, 2025 at 04:02:19PM +0200, AngeloGioacchino Del Regno wrote:
> > Add bindings for the regulators found in the MediaTek MT6363 PMIC,
> > usually found in board designs using the MT6991 Dimensity 9400 and
> > on MT8196 Kompanio SoC for Chromebooks, along with the MT6316 and
> > MT6373 PMICs.
> >
> > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
> > ---
> >  .../regulator/mediatek,mt6363-regulator.yaml  | 193 ++++++++++++++++++
> >  1 file changed, 193 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/regulator/mediatek,mt6363-regulator.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/regulator/mediatek,mt6363-regulator.yaml b/Documentation/devicetree/bindings/regulator/mediatek,mt6363-regulator.yaml
> > new file mode 100644
> > index 000000000000..ea1f6c92cffc
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/regulator/mediatek,mt6363-regulator.yaml
> > @@ -0,0 +1,193 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/regulator/mediatek,mt6363-regulator.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: MediaTek MT6363 PMIC Regulators
> > +
> > +maintainers:
> > +  - AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
> > +
> > +description:
> > +  The MT6363 SPMI PMIC provides 10 BUCK and 25 LDO (Low DropOut) regulators
> > +  and can optionally provide overcurrent warnings with one ocp interrupt
> > +  for each voltage regulator.
> > +
> > +properties:
> > +  compatible:
> > +    const: mediatek,mt6363-regulator
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  vsys-vbuck1-supply:
> > +    description: Input supply for vbuck1
>
> blank line
>
> > +  vsys-vbuck2-supply:
> > +    description: Input supply for vbuck2
>
> blank line, and so on...
>
> > +  vsys-vbuck3-supply:
> > +    description: Input supply for vbuck3
> > +  vsys-vbuck4-supply:
> > +    description: Input supply for vbuck4
> > +  vsys-vbuck5-supply:
> > +    description: Input supply for vbuck5
> > +  vsys-vbuck6-supply:
> > +    description: Input supply for vbuck6
> > +  vsys-vbuck7-supply:
> > +    description: Input supply for vbuck7
> > +  vsys-vs1-supply:
> > +    description: Input supply for vs1
> > +  vsys-vs2-supply:
> > +    description: Input supply for vs2
> > +  vsys-vs3-supply:
> > +    description: Input supply for vs3

You could also merge the ones above with a regex and move it to
patternProperties. Since these are one to one mappings that should
work still.

> > +  vs1-ldo1-supply:
> > +    description: Input supply for va15, vio0p75, vm18, vrf18, vrf-io18
> > +  vs1-ldo2-supply:
> > +    description: Input supply for vcn15, vio18, vufs18
> > +  vs2-ldo1-supply:
> > +    description: Input supply for vsram-cpub, vsram-cpum, vrf12, vrf13, vufs12
> > +  vs2-ldo2-supply:
> > +    description: Input supply for va12-1, va12-2, vcn13, vsram-cpul
> > +  vs3-ldo1-supply:
> > +    description: Input supply for vsram-apu, vsram-digrf, vsram-mdfe
> > +  vs3-ldo2-supply:
> > +    description: Input supply for vsram-modem, vrf0p9
> > +  vsys-ldo1-supply:
> > +    description: Input supply for vaux18, vemc, vtref18

For these, I wonder if the description is really needed.

>From a device tree writing point of view, the author is likely looking
at the diagram and tracing each of these pins to a supply. They won't
care which LDO it's actually feeding.

>From an implementer POV, the author is likely looking at the datasheet
for other details not spelled out here, such as voltage steps and
register offsets. The datasheet also says which supply pin feeds into
which LDOs.

ChenYu