linux-kernel - Re: [PATCH v2] f2fs: zone: wait for inflight dio completion, excluding pinned files read using dio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <33e75ec8-9bf4-4c45-b706-a2e6b6cd8413@kernel.org>
Date: Tue, 22 Jul 2025 13:51:53 +0800
From: Chao Yu <chao@...nel.org>
To: "yohan.joung" <yohan.joung@...com>, jaegeuk@...nel.org
Cc: chao@...nel.org, linux-kernel@...r.kernel.org,
 linux-f2fs-devel@...ts.sourceforge.net, pilhyun.kim@...com
Subject: Re: [PATCH v2] f2fs: zone: wait for inflight dio completion,
 excluding pinned files read using dio

On 7/22/25 13:20, yohan.joung wrote:
> read for the pinfile using Direct I/O do not wait for dio write.
> 
> Signed-off-by: yohan.joung <yohan.joung@...com>
> ---
>  fs/f2fs/file.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> index 4039ccb5022c..2b7e5c46c1ae 100644
> --- a/fs/f2fs/file.c
> +++ b/fs/f2fs/file.c
> @@ -4834,6 +4834,7 @@ static ssize_t f2fs_file_read_iter(struct kiocb *iocb, struct iov_iter *to)
>  	struct inode *inode = file_inode(iocb->ki_filp);
>  	const loff_t pos = iocb->ki_pos;
>  	ssize_t ret;
> +	bool dio;
>  
>  	if (!f2fs_is_compress_backend_ready(inode))
>  		return -EOPNOTSUPP;
> @@ -4842,12 +4843,15 @@ static ssize_t f2fs_file_read_iter(struct kiocb *iocb, struct iov_iter *to)
>  		f2fs_trace_rw_file_path(iocb->ki_filp, iocb->ki_pos,
>  					iov_iter_count(to), READ);
>  
> +	dio = f2fs_should_use_dio(inode, iocb, to);
> +
>  	/* In LFS mode, if there is inflight dio, wait for its completion */
>  	if (f2fs_lfs_mode(F2FS_I_SB(inode)) &&
> -	    get_pages(F2FS_I_SB(inode), F2FS_DIO_WRITE))
> +	    get_pages(F2FS_I_SB(inode), F2FS_DIO_WRITE) &&
> +		!(f2fs_is_pinned_file(inode) && dio))

How about?

(!f2fs_is_pinned_file(inode) || !dio)

Thanks,

>  		inode_dio_wait(inode);
>  
> -	if (f2fs_should_use_dio(inode, iocb, to)) {
> +	if (dio) {
>  		ret = f2fs_dio_read_iter(iocb, to);
>  	} else {
>  		ret = filemap_read(iocb, to, 0);