lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <2025072228-comfy-germproof-578d@gregkh>
Date: Tue, 22 Jul 2025 07:53:39 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Rujra Bhatt <braker.noob.kernel@...il.com>
Cc: geert@...ux-m68k.org, linux-m68k@...ts.linux-m68k.org,
	linux-kernel@...r.kernel.org, skhan@...uxfoundation.org,
	linux-kernel-mentees@...ts.linux.dev
Subject: Re: [PATCH] drivers:zorro:zorro-sysfs.c Replace sprintf() with
 sysfs_emit()

On Tue, Jul 22, 2025 at 09:09:08AM +0530, Rujra Bhatt wrote:
> Reply-To: 

Why is this here?

> 
> replace sprintf() with sysfs_emit() in sysfs
> *_show() functions in zorro-sysfs.c to follow the kernel's guidelines
> from Documentation/filesystems/sysfs.rst.
> 
> This improves consistency, safety, and makes the code easier to
> maintain and update in the future.

No, not really.  For new code, always use sysfs_emit().  For existing
code, that you can not even test, just leave it alone unless you can
prove it is wrong.

This code looks fine as-is.  No need to change it unless you really want
to, but there is no requriement.

thanks,

greg k-h

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ