linux-kernel - Re: [PATCH 2/4] drm/bridge: imx: add driver for HDMI TX Parallel Audio Interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <85f1b9f3-0134-4385-9ac6-f3c6c2eb546f@nxp.com>
Date: Tue, 22 Jul 2025 15:52:11 +0800
From: Liu Ying <victor.liu@....com>
To: Shengjiu Wang <shengjiu.wang@...il.com>,
 Alexander Stein <alexander.stein@...tq-group.com>
Cc: andrzej.hajda@...el.com, neil.armstrong@...aro.org, rfoss@...nel.org,
 Laurent.pinchart@...asonboard.com, jonas@...boo.se,
 jernej.skrabec@...il.com, maarten.lankhorst@...ux.intel.com,
 mripard@...nel.org, tzimmermann@...e.de, airlied@...il.com, simona@...ll.ch,
 lumag@...nel.org, dianders@...omium.org, cristian.ciocaltea@...labora.com,
 luca.ceresoli@...tlin.com, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org, shawnguo@...nel.org, s.hauer@...gutronix.de,
 kernel@...gutronix.de, festevam@...il.com, imx@...ts.linux.dev,
 linux-arm-kernel@...ts.infradead.org, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, p.zabel@...gutronix.de, devicetree@...r.kernel.org,
 l.stach@...gutronix.de, Shengjiu Wang <shengjiu.wang@....com>
Subject: Re: [PATCH 2/4] drm/bridge: imx: add driver for HDMI TX Parallel
 Audio Interface

Hi Shengjiu,

On 07/21/2025, Shengjiu Wang wrote:
> On Fri, Jul 18, 2025 at 7:51 PM Alexander Stein
> <alexander.stein@...tq-group.com> wrote:

[...]

>> Am Freitag, 18. Juli 2025, 12:11:48 CEST schrieb Shengjiu Wang:

[...]

>>> +     /* IEC60958 format */
>>> +     val = 31 << FIELD_CTRL_P_SEL_SHIFT;
>>> +     val |= 30 << FIELD_CTRL_C_SEL_SHIFT;
>>> +     val |= 29 << FIELD_CTRL_U_SEL_SHIFT;
>>> +     val |= 28 << FIELD_CTRL_V_SEL_SHIFT;
>>> +     val |= 4 << FIELD_CTRL_D_SEL_SHIFT;
>>> +     val |= 0 << FIELD_CTRL_PRE_SEL_SHIFT;

[...]

>> But where do these numbers come from? I can see that downstream kernel
>> sets these bits depending on audio config being passed.
> 
> These numbers are defined in standard IEC958 spec.

Can these be defined by macros, even in a certain common header file,
include/sound/asoundef.h?

-- 
Regards,
Liu Ying