linux-kernel - Re: [PATCH] accel/ivpu: Remove lockdep_assert_irqs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f14e9187-e3b1-494d-b04f-9e7875a17e5a@linux.intel.com>
Date: Tue, 22 Jul 2025 09:53:46 +0200
From: Jacek Lawrynowicz <jacek.lawrynowicz@...ux.intel.com>
To: Maarten Lankhorst <dev@...khorst.se>,
 Maciej Falkowski <maciej.falkowski@...ux.intel.com>,
 Oded Gabbay <ogabbay@...nel.org>,
 Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
 Clark Williams <clrkwllms@...nel.org>, Steven Rostedt <rostedt@...dmis.org>
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
 linux-rt-devel@...ts.linux.dev
Subject: Re: [PATCH] accel/ivpu: Remove lockdep_assert_irqs_disabled()

Reviewed-by: Jacek Lawrynowicz <jacek.lawrynowicz@...ux.intel.com>

On 7/15/2025 6:59 PM, Maarten Lankhorst wrote:
> This breaks on PREEMPT_RT, and should be unneeded since
> lockdep can track irq disabled status itself.
> 
> Signed-off-by: Maarten Lankhorst <dev@...khorst.se>
> ---
>  drivers/accel/ivpu/ivpu_ipc.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/accel/ivpu/ivpu_ipc.c b/drivers/accel/ivpu/ivpu_ipc.c
> index 39f83225c1815..5f00809d448af 100644
> --- a/drivers/accel/ivpu/ivpu_ipc.c
> +++ b/drivers/accel/ivpu/ivpu_ipc.c
> @@ -141,7 +141,6 @@ ivpu_ipc_rx_msg_add(struct ivpu_device *vdev, struct ivpu_ipc_consumer *cons,
>  	struct ivpu_ipc_rx_msg *rx_msg;
>  
>  	lockdep_assert_held(&ipc->cons_lock);
> -	lockdep_assert_irqs_disabled();
>  
>  	rx_msg = kzalloc(sizeof(*rx_msg), GFP_ATOMIC);
>  	if (!rx_msg) {