linux-kernel - Re: [PATCH] accel/ivpu: Remove lockdep_assert_irqs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <60257b86-bba4-4f52-a5e4-1e4caeb3412f@lankhorst.se>
Date: Tue, 22 Jul 2025 10:28:06 +0200
From: Maarten Lankhorst <dev@...khorst.se>
To: Jacek Lawrynowicz <jacek.lawrynowicz@...ux.intel.com>,
 Maciej Falkowski <maciej.falkowski@...ux.intel.com>,
 Oded Gabbay <ogabbay@...nel.org>,
 Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
 Clark Williams <clrkwllms@...nel.org>, Steven Rostedt <rostedt@...dmis.org>
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
 linux-rt-devel@...ts.linux.dev
Subject: Re: [PATCH] accel/ivpu: Remove lockdep_assert_irqs_disabled()

Hey,

Den 2025-07-22 kl. 09:53, skrev Jacek Lawrynowicz:
> Reviewed-by: Jacek Lawrynowicz <jacek.lawrynowicz@...ux.intel.com>

Thanks, pushed to misc-next.

Best regards,
~Maarten
 
> On 7/15/2025 6:59 PM, Maarten Lankhorst wrote:
>> This breaks on PREEMPT_RT, and should be unneeded since
>> lockdep can track irq disabled status itself.
>>
>> Signed-off-by: Maarten Lankhorst <dev@...khorst.se>
>> ---
>>  drivers/accel/ivpu/ivpu_ipc.c | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/accel/ivpu/ivpu_ipc.c b/drivers/accel/ivpu/ivpu_ipc.c
>> index 39f83225c1815..5f00809d448af 100644
>> --- a/drivers/accel/ivpu/ivpu_ipc.c
>> +++ b/drivers/accel/ivpu/ivpu_ipc.c
>> @@ -141,7 +141,6 @@ ivpu_ipc_rx_msg_add(struct ivpu_device *vdev, struct ivpu_ipc_consumer *cons,
>>  	struct ivpu_ipc_rx_msg *rx_msg;
>>  
>>  	lockdep_assert_held(&ipc->cons_lock);
>> -	lockdep_assert_irqs_disabled();
>>  
>>  	rx_msg = kzalloc(sizeof(*rx_msg), GFP_ATOMIC);
>>  	if (!rx_msg) {
>