linux-kernel - Re: [PATCH 4/6] rv: Remove rv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250722082740.a0kYzRv_@linutronix.de>
Date: Tue, 22 Jul 2025 10:27:40 +0200
From: Nam Cao <namcao@...utronix.de>
To: Gabriele Monaco <gmonaco@...hat.com>
Cc: Steven Rostedt <rostedt@...dmis.org>,
	Masami Hiramatsu <mhiramat@...nel.org>,
	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
	linux-trace-kernel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/6] rv: Remove rv_reactor's reference counter

On Mon, Jul 21, 2025 at 05:49:02PM +0200, Gabriele Monaco wrote:
> Yeah I get your point. If I understand you correctly, what's broken is
> that we just return EBUSY and ignore that on __exit instead of doing
> something about it (set nop to all monitors using this reactor).

Yeah, EBUSY is ignored.

> I wonder if we shouldn't also fix this (using the module refcount).
> But that can be done in the future, I'm not even sure reactors as
> modules currently work.

Yes, let's worry about it when we allow building reactors as modules.

> Also, I'd need to verify this but depending on the order of exit
> functions, we might be seeing the same problems with built-in reactors
> when active on shutdown. I'm going to play a bit with this and see if
> this workaround of not deleting the reactor was introduced for that (I
> doubt though).

I'm not sure I follow. exit functions are never called for built-in
reactors. They are even discarded out of the built image.

Nam