linux-kernel - Re: [PATCH v3 1/2] dt-bindings: arm: Add Qualcomm extended CTI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250722091425.GH3137075@e132581.arm.com>
Date: Tue, 22 Jul 2025 10:14:25 +0100
From: Leo Yan <leo.yan@....com>
To: Suzuki K Poulose <suzuki.poulose@....com>
Cc: Mao Jinlong <quic_jinlmao@...cinc.com>,
	Mike Leach <mike.leach@...aro.org>,
	James Clark <james.clark@...aro.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Yingchao Deng <quic_yingdeng@...cinc.com>,
	coresight@...ts.linaro.org, linux-arm-kernel@...ts.infradead.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: arm: Add Qualcomm extended CTI

On Tue, Jul 22, 2025 at 09:49:28AM +0100, Suzuki Kuruppassery Poulose wrote:
> On 22/07/2025 09:14, Mao Jinlong wrote:
> > From: Yingchao Deng <quic_yingdeng@...cinc.com>
> > 
> > Add Qualcomm extended CTI support in CTI binding file. Qualcomm
> > extended CTI supports up to 128 triggers.
> > 
> > Signed-off-by: Yingchao Deng <quic_yingdeng@...cinc.com>
> > Signed-off-by: Mao Jinlong <quic_jinlmao@...cinc.com>
> > ---
> >   Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml | 4 +++-
> >   1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml
> > index 2d5545a2b49c..1aa27461f5bc 100644
> > --- a/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml
> > +++ b/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml
> > @@ -84,7 +84,9 @@ properties:
> >             - const: arm,coresight-cti
> >             - const: arm,primecell
> >         - items:
> > -          - const: arm,coresight-cti-v8-arch
> > +          - enum:
> > +              - arm,coresight-cti-v8-arch
> > +              - qcom,coresight-cti-extended
> 
> Why not call it qcom,coresight-cti ?
> 
> There are no other "qcom,coresight-cti", so "extended" is not required.
> Is this specific to CPU (i.e., CPU bound) ?

I roughly went through the second path. Combining two patches in this
series, I am wandering if can directly check registers (e.g. PID/CID)
to find CTI with qcom extension. If so, you do not need an extra DT
binding, right?

Thanks,
Leo

> Suzuki
> 
> >             - const: arm,coresight-cti
> >             - const: arm,primecell
> 
> _______________________________________________
> CoreSight mailing list -- coresight@...ts.linaro.org
> To unsubscribe send an email to coresight-leave@...ts.linaro.org