linux-kernel - Re: [PATCH net-next] vxlan: remove redundant conversion of vni in vxlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <97be4c1a-f097-4780-b5e6-71c0530f3f49@blackwall.org>
Date: Tue, 22 Jul 2025 12:19:47 +0300
From: Nikolay Aleksandrov <razor@...ckwall.org>
To: Wang Liang <wangliang74@...wei.com>, andrew+netdev@...n.ch,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, idosch@...dia.com, petrm@...dia.com,
 menglong8.dong@...il.com
Cc: yuehaibing@...wei.com, zhangchangzhong@...wei.com,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] vxlan: remove redundant conversion of vni in
 vxlan_nl2conf

On 7/22/25 12:30, Wang Liang wrote:
> The IFLA_VXLAN_ID data has been converted to local variable vni in
> vxlan_nl2conf(), there is no need to do it again when set conf->vni.
> 
> Signed-off-by: Wang Liang <wangliang74@...wei.com>
> ---
>  drivers/net/vxlan/vxlan_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/vxlan/vxlan_core.c b/drivers/net/vxlan/vxlan_core.c
> index 97792de896b7..77dbfe9a6b13 100644
> --- a/drivers/net/vxlan/vxlan_core.c
> +++ b/drivers/net/vxlan/vxlan_core.c
> @@ -4036,7 +4036,7 @@ static int vxlan_nl2conf(struct nlattr *tb[], struct nlattr *data[],
>  			NL_SET_ERR_MSG_ATTR(extack, tb[IFLA_VXLAN_ID], "Cannot change VNI");
>  			return -EOPNOTSUPP;
>  		}
> -		conf->vni = cpu_to_be32(nla_get_u32(data[IFLA_VXLAN_ID]));
> +		conf->vni = vni;
>  	}
>  
>  	if (data[IFLA_VXLAN_GROUP]) {

Acked-by: Nikolay Aleksandrov <razor@...ckwall.org>